Improve Worksheet.sort() signature
#1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using generic `kwargs` Mention the argument `range` explicitly and add it's type. closes #1090 Signed-off-by: Alexandre Lavigne <[email protected]>
lavigne958
force-pushed
the
improvement/change_sort_signaure
branch
from
0cb61b6 to
e453155
Compare
|
I based this branch from missing type hints. When she base merged this PR should automatically change its base to feature/release_6_0_0 |
Base automatically changed from
1321-add-missing-type-hints
to
feature/release_6_0_0
November 1, 2023 17:16
alifeee
approved these changes
Nov 1, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using generic
kwargsMention the argument
rangeexplicitly and add it's type.closes #1090
Signed-off-by: Alexandre Lavigne [email protected]