-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make 6.0.0 release #1359
Comments
I think that's all, just check the readme is up to date then we can merge the branch and master together. The. Release |
See #1360, I'm curious if you want to tweak the API of |
We may change the warnings emitted in previous versions, but we will not tweak the APIs as that would be against the ideals of semantic versioning |
Ah yes, I meant adjust the the 6.x API (and adjust the 5.x warnings to be in sync), but not change the 5.x API. But it's a moot point, please ignore my previous comment. The 6.x API actually looks great, I just was reading the code on |
no problem , thank you for coming and giving us feedback that's gold for us. |
Out of curiosity, is there a planned date by when gspread 6.0 will be out? We're currently refactoring some of our bots, and curious when the update is supposed to be out at large |
Hello, we can't provide a date as of yet. We don't have a specific date but we should be able to release it after the issue #1367 is solved. I am currently very busy at work and can hardly find the time to review @alifeee 's PR. I hope this week we can merge his first part. As of now I would say at least a few weeks. |
Thank you for the information. And thanks for keeping this library updated, this has been a massive help! |
We need to wait for #1380 to be done Then we can release the new version. |
I have approved #1380 As for the release notes concern, this is what the release notes look like: show v6 release notesWhat's Changed
New Contributors
Full Changelog: v5.12.4...v6.0.0 I think that is fine to put in a release. I think that we can also put something at the top linking to the migration guide, and listing the biggest changes (typing, ...?) |
after #1380 is complete I will make release 6.0.0 on Sunday at 12:00pm UTC |
It is ! It's actually smaller than I thought. Yes a small line mentioning the migration guide is a good extra at the top of the release note. Yes we can add that too, we have: python version and typing so far. |
the release is made: https://github.com/burnash/gspread/releases/tag/v6.0.0 at some point in future we should remove the migration guide from the readme? in a few months/a year? feel free to change the release decription to be more descriptive, especially about the new client. now we wait... |
I think we can remove it when make the next major release.
Yeah I saw the extra description, I realized we did not take the proper time to build it. I'll check if anything is worth mentioning, like you said may be mention what the new client does ? I don't know 🙄
Ladies and gentlemen brace for impact 😬 |
we should
we should do this with plenty of time before xmas so that we can respond to (inevitable) incoming issues.
The text was updated successfully, but these errors were encountered: