Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make 6.0.0 release #1359

Closed
alifeee opened this issue Dec 3, 2023 · 14 comments
Closed

make 6.0.0 release #1359

alifeee opened this issue Dec 3, 2023 · 14 comments
Assignees
Milestone

Comments

@alifeee
Copy link
Collaborator

alifeee commented Dec 3, 2023

we should

  • look through the changes, and make sure the readme migration guide is up to date
  • anything else you can think of?

we should do this with plenty of time before xmas so that we can respond to (inevitable) incoming issues.

@alifeee alifeee added this to the 6.0.0 milestone Dec 3, 2023
@lavigne958
Copy link
Collaborator

I think that's all, just check the readme is up to date then we can merge the branch and master together. The. Release

@NickCrews
Copy link
Contributor

NickCrews commented Dec 4, 2023

See #1360, I'm curious if you want to tweak the API of Worksheet.update() before you make this release. Thank you for all your effort in maintaining this lib!

@alifeee
Copy link
Collaborator Author

alifeee commented Dec 4, 2023

See #1360, I'm curious if you want to tweak the API of Worksheet.update() before you make this release. Thank you for all your effort in maintaining this lib!

We may change the warnings emitted in previous versions, but we will not tweak the APIs as that would be against the ideals of semantic versioning

@NickCrews
Copy link
Contributor

Ah yes, I meant adjust the the 6.x API (and adjust the 5.x warnings to be in sync), but not change the 5.x API.

But it's a moot point, please ignore my previous comment. The 6.x API actually looks great, I just was reading the code on master instead of on the feature/release_6_0_0 branch and was therefore confused :).

@lavigne958
Copy link
Collaborator

no problem , thank you for coming and giving us feedback that's gold for us.
If the warning is fine then we'll keep going with our schedule.

@TheOriginalSoni
Copy link

Out of curiosity, is there a planned date by when gspread 6.0 will be out? We're currently refactoring some of our bots, and curious when the update is supposed to be out at large

@lavigne958
Copy link
Collaborator

Hello, we can't provide a date as of yet.

We don't have a specific date but we should be able to release it after the issue #1367 is solved.

I am currently very busy at work and can hardly find the time to review @alifeee 's PR.

I hope this week we can merge his first part.
Next week may be I can do my part.

As of now I would say at least a few weeks.

@TheOriginalSoni
Copy link

Thank you for the information. And thanks for keeping this library updated, this has been a massive help!

@lavigne958
Copy link
Collaborator

We need to wait for #1380 to be done

Then we can release the new version.

@alifeee
Copy link
Collaborator Author

alifeee commented Jan 26, 2024

I have approved #1380

As for the release notes concern, this is what the release notes look like:

show v6 release notes

What's Changed

New Contributors

Full Changelog: v5.12.4...v6.0.0

I think that is fine to put in a release. I think that we can also put something at the top linking to the migration guide, and listing the biggest changes (typing, ...?)

@alifeee
Copy link
Collaborator Author

alifeee commented Jan 26, 2024

after #1380 is complete I will make release 6.0.0 on Sunday at 12:00pm UTC

@lavigne958
Copy link
Collaborator

I have approved #1380

As for the release notes concern, this is what the release notes look like:

show v6 release notes

What's Changed

New Contributors

Full Changelog: v5.12.4...v6.0.0

I think that is fine to put in a release. I think that we can also put something at the top linking to the migration guide, and listing the biggest changes (typing, ...?)

It is ! It's actually smaller than I thought.

Yes a small line mentioning the migration guide is a good extra at the top of the release note.

Yes we can add that too, we have: python version and typing so far.

@alifeee
Copy link
Collaborator Author

alifeee commented Jan 28, 2024

the release is made: https://github.com/burnash/gspread/releases/tag/v6.0.0

at some point in future we should remove the migration guide from the readme? in a few months/a year?

feel free to change the release decription to be more descriptive, especially about the new client.

now we wait...

@alifeee alifeee closed this as completed Jan 28, 2024
@lavigne958
Copy link
Collaborator

lavigne958 commented Jan 28, 2024

the release is made: https://github.com/burnash/gspread/releases/tag/v6.0.0

at some point in future we should remove the migration guide from the readme? in a few months/a year?

I think we can remove it when make the next major release.
Once 7.0.0 is out. No need for migration guide from 5 to 6.
At that time we can move it the documentation for the record, do anyone waking up late can still find it 🤔

feel free to change the release decription to be more descriptive, especially about the new client.

Yeah I saw the extra description, I realized we did not take the proper time to build it. I'll check if anything is worth mentioning, like you said may be mention what the new client does ? I don't know 🙄

now we wait...

Ladies and gentlemen brace for impact 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants