Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated l10n for 1.74.x release (lowered from 1.74.x) #27217

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

mkarolin
Copy link
Collaborator

Resolves brave/brave-browser#43209
Resolves brave/brave-browser#43126

Lowered from #27207

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin requested a review from kjozwiak January 14, 2025 00:48
@mkarolin mkarolin self-assigned this Jan 14, 2025
* Adds timeout parameter in Crowdin API wrapper.

* Updated l10n for 1.74.x release.
@mkarolin mkarolin force-pushed the maxk-1.74.x-release-l10n-master branch from f085b45 to 3adc0e4 Compare January 14, 2025 14:20
@kjozwiak kjozwiak added this to the 1.76.x - Nightly milestone Jan 14, 2025
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Merging as the above was already merged into 1.74.x & 1.75.x.

@kjozwiak kjozwiak merged commit 5e2b579 into master Jan 14, 2025
18 checks passed
@kjozwiak kjozwiak deleted the maxk-1.74.x-release-l10n-master branch January 14, 2025 17:12
@brave-builds
Copy link
Collaborator

Released in v1.76.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update l10n for 1.74.x (Chromium 132). ads is not capitalized to Ads in non-connected state
3 participants