-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix downloads button positioning and interactivity #27112
Conversation
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "policy" and so security team members have been added as reviewers to take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chromium_src
LGTM
A Storybook has been deployed to preview UI for the latest push |
@thypon @kdenhartog This PR just mentions the word "policy" as the change slightly tweaks the UI for the downloads page for managed users, which is set via group policy. There are no changes beyond CSS. |
approved |
Released in v1.75.147 |
Resolves brave/brave-browser#42924
This PR hides the "managed footnote" on brave://downloads, since our version of the downloads page doesn't have a static area to display the footnote (unlike the upstream page). For the same reason, we add some margin-right to the "Clear All" button so it doesn't overlap with teh scrollbar when the list of download items is long.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: