Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't click "Clear all" button on brave://downloads/ #42924

Closed
1 of 6 tasks
JaneX8 opened this issue Dec 16, 2024 · 13 comments · Fixed by brave/brave-core#27112
Closed
1 of 6 tasks

Can't click "Clear all" button on brave://downloads/ #42924

JaneX8 opened this issue Dec 16, 2024 · 13 comments · Fixed by brave/brave-core#27112

Comments

@JaneX8
Copy link

JaneX8 commented Dec 16, 2024

Description

I cannot click the Clear all button for quite some time now. It also is behind a scroll bar. I can only tab through to the button and the hit enter. But using the mouse it does not work.

Image

Windows 11.

Image

Resolution 1920x1080. 100% scale. Landscape. Both when using a single or multiple (three) displays. Same resolution. Install location: "C:\Program Files\BraveSoftware\Brave-Browser\Application\brave.exe".

Steps to reproduce

Have the same OS, Brave version and resolutions

Actual result

Unclickable "Clear all" button on "brave://downloads/"

Expected result

Clickable "Clear all" button.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.73.101 Chromium: 131.0.6778.139 (Official Build) (64-bit)
45dae32a9fd5d259796f6c975ec055564fac7139
Windows 11 Version 23H2 (Build 22631.4602)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

Possibly installed using scoop.sh or WinGet Package Manager.

@LegalizeNukes
Copy link

Same issue occurs on macOS.

@JaneX8 JaneX8 changed the title Can't click "Clear all" button on Windows Can't click "Clear all" button on Windows and macOS Dec 17, 2024
@dushmanta05
Copy link

Have the same alignment issue on Linux (Ubuntu 24.04) although the "Clear All" functionality is working.

Image

@rebron rebron changed the title Can't click "Clear all" button on Windows and macOS Can't click "Clear all" button on brave://downloads/ Dec 18, 2024
@rebron rebron added feature/download priority/P2 A bad problem. We might uplift this to the next planned release. labels Dec 18, 2024
@rebron rebron added this to General Dec 18, 2024
@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include QA/Test-All-Platforms priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P2 A bad problem. We might uplift this to the next planned release. priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 18, 2024
@rebron rebron moved this to On Deck in General Dec 18, 2024
@emerick
Copy link
Contributor

emerick commented Dec 18, 2024

I wasn't able to repro on Windows/Mac at various resolutions (I'm always able to interact with the "Clear" button, though it does overlap the toolbar). @brave/qa-team if we have any clear repro steps on this one, please let me know!

@LaurenWags
Copy link
Member

@emerick unfortunately I haven't been able to reproduce the inability to click the "Clear" button on brave://downloads, I do see the overlap issue though. Hopefully some others from @brave/qa-team can try - perhaps @MadhaviSeelam or @GeetaSarvadnya can look on their Win machines.

Brave | 1.73.104 Chromium: 131.0.6778.204 (Official Build) (x86_64)
-- | --
Revision | 215b794a7c1f3e28151d0f7712e32c71be48775c
OS | macOS Version 14.7.2 (Build 23H311)
Image

Have tried:

  • various resolutions
  • various window sizes
  • full screen vs not full screen

@JaneX8 could you try something when you get a chance?

  1. Open brave://downloads
  2. Right click somewhere on the page and select "Inspect" from the context menu:
Image
  1. When the devtools open, near the top click on "Console"
Image
  1. Can you let us know if there are any errors displayed here? (You see mine doesn't show any in the above screenshot)

@JaneX8
Copy link
Author

JaneX8 commented Dec 20, 2024

Hi,
I have very little time but I quickly checked what you asked. No errors are shown in the console. It's identical to your last screenshot. Maybe this helps, the button seems only clickable when you're effectively on top of the scroll bar in a tiny area:

Schermopname.2024-12-20.112953.mp4

I can confirm the issue: managed-footnote has covers the clear all cr-button button. Maybe z-index? If I delete the managed-footnote element entirely the button works again. I get the managed footnote because I used the registry to programmatically install Brave extensions.

Image

@LaurenWags
Copy link
Member

@JaneX8 this looks promising. I don't have that "managed" message so that could be why I can't reproduce on my set up. I'll give it a try and report back. Thank you!

@LegalizeNukes
Copy link

I would like to add that I also have the "managed" message. The problem may indeed be related to it.

@LaurenWags
Copy link
Member

Thanks @JaneX8 @LegalizeNukes - I can reliably reproduce the issue when "Your browser is managed by your organization" message is shown on brave://downloads 👍🏻


@emerick the steps I used to reproduce are:

  1. Using 1.73.104 (current release), downloaded a bunch of files
  2. Confirmed "Clear" works fine (used the "undo" action to get my list back)
no.policy.mov
  1. Closed the browser
  2. Added a policy via terminal (ex. ran defaults write com.brave.Browser BraveVPNDisabled -bool true on macOS) to get the "managed" message
  3. Relaunched the browser
  4. On brave://downloads confirmed I can see the "Your browser is managed by your organization" message
  5. Confirmed the "Clear" button doesn't work unless I go to the far right edge as mentioned by @JaneX8 - can see it doesn't highlight until getting to that far right edge. When I click there it does work and it can be "undone"
policy.mov

To clean up/remove the policy I then closed the browser, removed the policy I had set via the terminal (ran defaults delete com.brave.Browser BraveVPNDisabled), relaunched and saw that the "managed" message was removed.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Dec 20, 2024

Indeed, reproduced the issue with a policy enabled i.e. "Your browser is managed by your organization" message is shown. If a policy is not configured, working as expected in below build in Win 11 x64

Brave | 1.73.104 Chromium: 131.0.6778.204 (Official Build) (64-bit)
-- | --
Revision | 215b794a7c1f3e28151d0f7712e32c71be48775c
OS | Windows 11 Version 24H2 (Build 26100.2314)
2024-12-20_09h17_30.mp4

@emerick
Copy link
Contributor

emerick commented Dec 20, 2024

I think we should probably hide the managed footnote on the downloads, as it's incompatible with how our toolbar is implemented.

@fallaciousreasoning I think I could use some advice on how to hide managed-footnote just on brave://downloads. Not sure if I'm missing an obvious approach, but nothing I tried seems to work. Was hoping I could use a style injection.

@JaneX8
Copy link
Author

JaneX8 commented Dec 21, 2024

My bet is something like

managed-footnote {
display: none !important;
}

I didn't test it. Also should probably give someore margin-right to the button so it doesn't show behind the scroll bar but next to it.

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 7, 2025
@LaurenWags
Copy link
Member

LaurenWags commented Jan 7, 2025

Verified with

Brave | 1.75.150 Chromium: 132.0.6834.57 (Official Build) nightly (arm64)
-- | --
Revision | b219fae63dd08e4d2ebc645c6add777a8beb055b
OS | macOS Version 15.3 (Build 24D5034f)

Used 1.74.44 Chromium: 132.0.6834.57 and STR from #42924 (comment) to reproduce the issue:

  1. Using 1.74.44 (beta), downloaded a bunch of files
  2. Closed the browser
  3. Added a policy via terminal (ex. ran defaults write com.brave.Browser.beta BraveVPNDisabled -bool true on macOS) to get the "managed" message
  4. Relaunched the browser
  5. On brave://downloads confirmed I can see the "Your browser is managed by your organization" message
  6. Confirmed the "Clear" button doesn't work. Note, going to the far edge didn't work as it did previously - I couldn't select the button at all.
beta.mov

To clean up/remove the policy I then closed the browser, removed the policy I had set via the terminal (ran defaults delete com.brave.Browser.beta BraveVPNDisabled), relaunched and saw that the "managed" message was removed.

Using 1.75.150 Chromium: 132.0.6834.57 verified the same STR as well as the test plan from brave/brave-core#27112 (comment):

  • Confirmed the "managed" message does not appear on brave://downloads when a policy is set up
  • Confirmed the "managed" message still appears on brave://settings (if applicable, it does not appear if there is no policy set)
  • Confirmed that "Clear all" button on brave://downloads works as expected when a policy is set (but no "managed" message appears)
  • Confirmed that "Clear all" does not overlap with scrollbar and can be selected if a scrollbar is visible on screen
nightly.mov

@LaurenWags LaurenWags added QA Pass-macOS-arm64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 7, 2025
@MadhaviSeelam
Copy link

MadhaviSeelam commented Jan 15, 2025

Verification PASSED using

Brave | 1.75.159 Chromium: 132.0.6834.83 (Official Build) beta (64-bit)
-- | --
Revision | a7b6f5093a2dad31fc3f56241a7d55be255e69e2
OS | Windows 11 Version 24H2 (Build 26100.2605)
  1. Installed 1.75.159
  2. launched Brave
  3. downloaded few files
  4. opened Local Group Policy Editor via gpedit.msc (Win + R)
  5. opened Administrative Templates >> Classic Administrative Templates (ADM)>> Brave >> Brave Software Settings
  6. double clicked to Disable Tor Connectivity
  7. selected Enabled >> Apply
  8. confirmed brave://downloadsdo not show the message "Yourbrowser is managed` by your organization"
  9. confirmed brave://settings/appearance is shown the message "Your browser is managed by your organization"
  10. returned brave://downloads
  11. clicked Clear all
  12. confirmed "Clear all" button on brave://downloads works as expected for all three scenarios, i.e. when a policy Enabled, Disabled and Not configured
2025-01-15_16h07_22.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

8 participants