Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Clear input values between Bridge and Swap #24574

Merged

Conversation

Douglashdaniel
Copy link
Contributor

Description

Fixes a bug where Input values were being persisted when navigating between the Bridge and Swap screens.

Resolves brave/brave-browser#39657

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Open the Wallet and navigate to the Swap screen
  2. Select some tokens to swap and enter an amount to get a quote
  3. Now navigate to the Bridge screen
  4. The input values should be cleared and not persisted.

Before:

Screen.Recording.6.mov

After:

Screen.Recording.7.mov

@Douglashdaniel Douglashdaniel self-assigned this Jul 9, 2024
@Douglashdaniel Douglashdaniel requested a review from a team as a code owner July 9, 2024 21:53
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet labels Jul 9, 2024
Copy link
Contributor

@josheleonard josheleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@Douglashdaniel Douglashdaniel enabled auto-merge July 9, 2024 23:28
@Douglashdaniel Douglashdaniel merged commit 3d2493a into master Jul 9, 2024
20 checks passed
@Douglashdaniel Douglashdaniel deleted the fix-wallet-clear-input-values-between-bridge-and-swap branch July 9, 2024 23:34
@github-actions github-actions bot added this to the 1.69.x - Nightly milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input values are persisted when switching between Swap and Bridge screens
3 participants