Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input values are persisted when switching between Swap and Bridge screens #39657

Closed
1 of 6 tasks
Douglashdaniel opened this issue Jul 9, 2024 · 1 comment · Fixed by brave/brave-core#24574
Closed
1 of 6 tasks

Input values are persisted when switching between Swap and Bridge screens #39657

Douglashdaniel opened this issue Jul 9, 2024 · 1 comment · Fixed by brave/brave-core#24574
Assignees
@Douglashdaniel
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.69.x - Release

Comments

@Douglashdaniel
Copy link

Description

Currently input values are being persisted when switching between the Swap and Bridge screens.

Steps to reproduce

  1. Open the Wallet and navigate to the Swap screen
  2. Select some tokens to swap and enter an amount to get a quote
  3. Now navigate to the Bridge screen
  4. You will see that the Input values are persisted along with the New quote countdown continues to count down.

Actual result

Screen.Recording.6.mov

Expected result

It should reset and clear all input fields.

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.69.88 Chromium: 127.0.6533.26 (Official Build) nightly (arm64)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response
@Douglashdaniel Douglashdaniel added bug QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Jul 9, 2024
@Douglashdaniel Douglashdaniel self-assigned this Jul 9, 2024
@Douglashdaniel Douglashdaniel moved this to In Progress in Web3 Jul 9, 2024
@Douglashdaniel Douglashdaniel mentioned this issue Jul 9, 2024
Merged
24 tasks
@Douglashdaniel Douglashdaniel moved this from In Progress to In Review in Web3 Jul 9, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jul 9, 2024
@brave-builds brave-builds added this to the 1.69.x - Nightly milestone Jul 9, 2024
@srirambv
Copy link
Contributor

srirambv commented Aug 5, 2024

Verification passed on

Brave 1.69.135 Chromium: 127.0.6533.88 (Official Build) beta (64-bit)
Revision 96e3ea6d105b9e3f1a388fa1838571774216b82e
OS Windows 11 Version 23H2 (Build 22631.3880)
  • Verified steps from brave/brave-core#24574
  • Verified input values are not persisted when switching between Swap and Bridge screens
39657.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Clear input values between Bridge and Swap brave/brave-core
3 participants
@srirambv @Douglashdaniel @brave-builds