Deprecate local node support and ipfs scheme #23808

vadimstruts · 2024-05-23T13:42:44Z

Resolves brave/brave-browser#37735

Submitter Checklist:

I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on
All relevant documentation has been updated, for instance:

Test Plan:

iOS IPFS Deprecation Test Plan:

open Brave iOS
Tap ...
Go to Settings/Web3
Observe that no IPFS related settings are displayed in the screen
Make sure all Web3 Domain settings are all set to Ask
Go back to home page
input an IPFS scheme url in omnibox. For example: ipfs://QmX4nfgA35MiW5APoc4P815hMcH8hAt7edi5H3wXkFm485/1688.html
No IPFS configuration interstitial page will be loaded. and IPFS url will not be resolved and loaded. A search will be performed instead.
Input a SNS url in omnibox. For example: http://onybose.sol/
An interstitial page will be loaded. Tap Proceed using an SNS server
Observe the SNS url is resolved and loaded
Go back to Settings/Web3. Observe Resolve SNS Domain Names is now set to Enabled
Change that to Ask abd go back to home page
Repeat step 9 and 10 but tap Disable
Observe an error page is loaded
Go back to Settings/Web3. Observe Resolve SNS Domain Names is now set to Disabled
Go back to home page and input a ENS url in omnibox. For example: http://offchainexample.eth/ (the resolved url is an IPFS scheme url)
An interstitial page will be loaded. Tap Proceed using infura server
Another interstitial page will be loaded. Tap Proceed with offchain lookup
observe the ENS is now resolved and loaded. The process is ENS -> offchain lookup -> IPFS url resolved. (Even though IPFS is deprecated. but for IPFS url that was the result of other Web3 Domain Names. BraveCore will resolve those IPFS urls using the public gateway https://ipfs.io/)
Go to Settings/Web3. Observe Resolve ENS Domain Names and Allow ENS Offchain Lookup are now set to Enable
Change them to Ask and go back home page
Repeat step 18 and 19 but tap Disable
Observe an error page is loaded
Change Resolve ENS Domain Names to Enabled in Settings/Web3
Go back to home and reload the error page
Another interstitial page will be loaded. Tap Disable
Observe an error page is loaded
Input an unstoppable domains in omnibox. For example: jim-unstoppable.crypto
Another interstitial page will be loaded. Tap Proceed using infura server
Observe the url is now resolved using the public gateway https://ipfs.io/
Go back to Settings/Web3 and disable Resolve Unstoppable Domains Domain Names
Repeat step 30
Observe an error page is loaded

brave-builds · 2024-05-23T20:40:49Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2024-05-24T10:17:01Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2024-05-25T10:47:34Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2024-05-27T16:57:27Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2024-05-27T18:33:24Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2024-05-27T19:18:56Z

A Storybook has been deployed to preview UI for the latest push

supermassive · 2024-05-28T08:20:27Z

components/brave_wallet/browser/test/BUILD.gn

    "//brave/components/json/rs:rust_lib",
    "//brave/components/resources:strings_grit",
    "//brave/components/services/brave_wallet/public/cpp/utils",
    "//brave/components/services/brave_wallet/public/mojom",
+    "//chrome/browser:browser",


components must not depend on chrome

supermassive · 2024-05-28T08:26:03Z

components/resources/wallet_strings.grdp

  <message name="IDS_BRAVE_WALLET_NFT_DETAIL_IMAGE_ADDRESS" desc="NFT detail image address category">Image URL</message>
-  <message name="IDS_BRAVE_WALLET_NFT_DETAILS_PINNING_IN_PROGRESS" desc="NFT detail pinning in progress">In progress</message>
-  <message name="IDS_BRAVE_WALLET_NFT_DETAILS_PINNING_SUCCESSFUL" desc="NFT detail pinning successful">Pinned</message>
-  <message name="IDS_BRAVE_WALLET_NFT_DETAILS_PINNING_FAILED" desc="NFT detail pinning failed">Failed</message>
  <message name="IDS_BRAVE_WALLET_NFT_DETAILS_OVERVIEW" desc="NFT detail overview">Overview</message>


There is still lots of WALLET_NFT_PINNING strings. Should we also clear them?

supermassive · 2024-05-28T08:27:49Z

components/brave_wallet/browser/brave_wallet_prefs.cc

+constexpr char kBraveIpfsFeatureMigrated[] = "brave.ipfs";
+constexpr char kBraveIpfsCompanionMigrated[] = "brave.ipfs_companion_enabled";
+constexpr char kPinnedNFTAssetsMigrated[] = "brave.wallet.user_pin_data";
+constexpr char kAutoPinEnabledMigrated[] = "brave.wallet.auto_pin_enabled";
+


Let's clear there only wallet prefs.

Also please add a comment with deprecation date (06/2024?) so we can remove them completely from code after a year

supermassive · 2024-05-28T08:46:39Z

components/constants/pref_names.h

@@ -62,7 +62,6 @@ inline constexpr char kAdControlType[] = "brave.ad_default";
 inline constexpr char kGoogleLoginControlType[] = "brave.google_login_default";
 inline constexpr char kWebTorrentEnabled[] = "brave.webtorrent_enabled";
 inline constexpr char kHangoutsEnabled[] = "brave.hangouts_enabled";
-inline constexpr char kIPFSCompanionEnabled[] = "brave.ipfs_companion_enabled";


Should be cleared with all other ipfs prefs I think

supermassive · 2024-05-28T08:51:55Z

components/brave_wallet_ui/common/async/base-query-cache.ts

-    return token.logo.startsWith('ipfs://')
-      ? (await this.getIpfsGatewayTranslatedNftUrl(token.logo)) || ''
-      : `chrome://erc-token-images/${token.logo}`
+    return `chrome://erc-token-images/${token.logo}`


getTokenLogo no longer needs to be async

how that would work if token.logo still starts with ipfs:// ?

supermassive · 2024-05-28T08:57:04Z

components/brave_wallet_ui/components/desktop/inspect-nfts/inspects-nfts.styles.ts

Don't need thiese styles anymore?

supermassive · 2024-05-28T08:57:46Z

components/brave_wallet_ui/components/desktop/local-ipfs-node/local-ipfs-node.tsx

@@ -47,31 +35,12 @@ interface Props {
 export const LocalIpfsNodeScreen = (props: Props) => {


Remove this file also?

supermassive · 2024-05-28T09:04:34Z

components/brave_wallet_ui/utils/routes-utils.ts

+    route.includes(WalletRoutes.Swap) ||
+    route.includes(WalletRoutes.Send) ||
+    route.includes(WalletRoutes.LocalIpfsNode)
  if (isPanel) {


why Swap and Send appear here?

brave-builds · 2024-05-31T13:45:27Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2024-06-03T17:35:00Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2024-06-03T20:15:50Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2024-06-03T21:16:59Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2024-06-03T23:01:36Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2024-06-04T06:20:29Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2024-06-04T07:21:23Z

A Storybook has been deployed to preview UI for the latest push

Signed-off-by: Vadym Struts <[email protected]>

brave-builds · 2024-07-08T20:46:26Z

A Storybook has been deployed to preview UI for the latest push

emerick · 2024-07-11T23:35:02Z

chromium_src/check_chromium_src_config.json5

-        "chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc": [
-            "CHROME_BROWSER_WEB_APPLICATIONS_COMMANDS_CLEAR_BROWSING_DATA_COMMAND_H_",
-            "CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_PROVIDER_H_",
-            "CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_UTILS_H_",
-        ],


Was this particular change intentional? I don't see how it's relevant to this PR, but I could definitely be missing something. Asking because check_chromium_src.py is now failing with the following messages:

Override chromium_src\chrome\browser\browsing_data\chrome_browsing_data_remover_delegate.cc defines symbol CHROME_BROWSER_WEB_APPLICATIONS_COMMANDS_CLEAR_BROWSING_DATA_COMMAND_H_ but the symbol could not be found in C:\work\brave-browser\src\chrome\browser\browsing_data\chrome_browsing_data_remover_delegate.cc and is not used internally in the override. ------------------------- [Error] chromium_src: Override chromium_src\chrome\browser\browsing_data\chrome_browsing_data_remover_delegate.cc defines symbol CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_PROVIDER_H_ but the symbol could not be found in C:\work\brave-browser\src\chrome\browser\browsing_data\chrome_browsing_data_remover_delegate.cc and is not used internally in the override. ------------------------- [Error] chromium_src: Override chromium_src\chrome\browser\browsing_data\chrome_browsing_data_remover_delegate.cc defines symbol CHROME_BROWSER_WEB_APPLICATIONS_WEB_APP_UTILS_H_ but the symbol could not be found in C:\work\brave-browser\src\chrome\browser\browsing_data\chrome_browsing_data_remover_delegate.cc and is not used internally in the override.

yes it was mistake, returned it back with PR: #24624

No worries, thank you for fixing!

chenjia404 · 2024-09-02T06:27:25Z

Can I install this feature separately? https://github.com/brave/brave-browser/wiki/IPFS-Features#import-and-sharing

vadimstruts linked an issue May 23, 2024 that may be closed by this pull request

Deprecate local node support and ipfs:// scheme brave/brave-browser#37735

Closed

vadimstruts force-pushed the 37735-consider-deprecating-local-node-support-and-ipfs-scheme branch from 3265207 to d6468fe Compare May 23, 2024 17:13

vadimstruts force-pushed the 37735-consider-deprecating-local-node-support-and-ipfs-scheme branch from ad4df82 to 6c92fe8 Compare May 27, 2024 10:37

vadimstruts force-pushed the 37735-consider-deprecating-local-node-support-and-ipfs-scheme branch from 10e5ba4 to 7807d26 Compare May 27, 2024 17:51

supermassive reviewed May 28, 2024

View reviewed changes

vadimstruts force-pushed the 37735-consider-deprecating-local-node-support-and-ipfs-scheme branch from 539c662 to bf9c57d Compare May 31, 2024 12:16

vadimstruts force-pushed the 37735-consider-deprecating-local-node-support-and-ipfs-scheme branch from cb5e312 to 3476084 Compare June 4, 2024 08:07

vadimstruts added 12 commits July 8, 2024 22:05

review fixes

58466bf

Signed-off-by: Vadym Struts <[email protected]>

fix format

ba960c1

Signed-off-by: Vadym Struts <[email protected]>

fix ios build

a50c2d5

Signed-off-by: Vadym Struts <[email protected]>

fix NFT adding after rebase

9994178

Signed-off-by: Vadym Struts <[email protected]>

removed uneeded code

dceaa96

Signed-off-by: Vadym Struts <[email protected]>

undo IPFS node cache deletion, fix unit tests

fef00cd

Signed-off-by: Vadym Struts <[email protected]>

removed uneeded code

152b81f

Signed-off-by: Vadym Struts <[email protected]>

fix code review suggestion

76cfba8

Signed-off-by: Vadym Struts <[email protected]>

fix code review suggestion

fa79b0c

Signed-off-by: Vadym Struts <[email protected]>

fix build after rebase

1d1d4d8

Signed-off-by: Vadym Struts <[email protected]>

removed unneded ts test + several review suggestions

02249fe

Signed-off-by: Vadym Struts <[email protected]>

added review suggestions

8dd42ab

Signed-off-by: Vadym Struts <[email protected]>

vadimstruts force-pushed the 37735-consider-deprecating-local-node-support-and-ipfs-scheme branch from b2f567a to 8dd42ab Compare July 8, 2024 20:09

iefremov approved these changes Jul 9, 2024

View reviewed changes

vadimstruts merged commit 43735ef into master Jul 9, 2024
19 checks passed

vadimstruts deleted the 37735-consider-deprecating-local-node-support-and-ipfs-scheme branch July 9, 2024 10:34

github-actions bot added this to the 1.69.x - Nightly milestone Jul 9, 2024

emerick reviewed Jul 11, 2024

View reviewed changes

vadimstruts mentioned this pull request Jul 12, 2024

Presubmit error due to deleted code in the check_chromium_src_config.json5 brave/brave-browser#39716

Closed

srirambv mentioned this pull request Jul 24, 2024

Deprecate local node support and ipfs:// scheme brave/brave-browser#37735

Closed

bsclifton mentioned this pull request Aug 6, 2024

Having local IPFS installed causes crash on certain pages (ex: when scrolling on MDN) brave/brave-browser#40102

Closed

6 tasks

vadimstruts mentioned this pull request Dec 6, 2024

Fixed browser crash when attempting to change 'Maximum IPFS Cache Siz… #23433

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate local node support and ipfs scheme #23808

Deprecate local node support and ipfs scheme #23808

vadimstruts commented May 23, 2024 •

edited

Loading

brave-builds commented May 23, 2024

brave-builds commented May 24, 2024

brave-builds commented May 25, 2024

brave-builds commented May 27, 2024

brave-builds commented May 27, 2024

brave-builds commented May 27, 2024

supermassive May 28, 2024

supermassive May 28, 2024 •

edited

Loading

supermassive May 28, 2024

supermassive May 28, 2024

supermassive May 28, 2024

supermassive May 28, 2024

supermassive May 28, 2024

supermassive May 28, 2024

supermassive May 28, 2024

supermassive May 28, 2024

brave-builds commented May 31, 2024

brave-builds commented Jun 3, 2024

brave-builds commented Jun 3, 2024

brave-builds commented Jun 3, 2024

brave-builds commented Jun 3, 2024

brave-builds commented Jun 4, 2024

brave-builds commented Jun 4, 2024

brave-builds commented Jul 8, 2024

emerick Jul 11, 2024

vadimstruts Jul 12, 2024

emerick Jul 12, 2024

chenjia404 commented Sep 2, 2024

		@@ -47,31 +35,12 @@ interface Props {
		export const LocalIpfsNodeScreen = (props: Props) => {

Deprecate local node support and ipfs scheme #23808

Deprecate local node support and ipfs scheme #23808

Conversation

vadimstruts commented May 23, 2024 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

brave-builds commented May 23, 2024

brave-builds commented May 24, 2024

brave-builds commented May 25, 2024

brave-builds commented May 27, 2024

brave-builds commented May 27, 2024

brave-builds commented May 27, 2024

Choose a reason for hiding this comment

supermassive May 28, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brave-builds commented May 31, 2024

brave-builds commented Jun 3, 2024

brave-builds commented Jun 3, 2024

brave-builds commented Jun 3, 2024

brave-builds commented Jun 3, 2024

brave-builds commented Jun 4, 2024

brave-builds commented Jun 4, 2024

brave-builds commented Jul 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chenjia404 commented Sep 2, 2024

vadimstruts commented May 23, 2024 •

edited

Loading

supermassive May 28, 2024 •

edited

Loading