added review suggestions

Signed-off-by: Vadym Struts <[email protected]>
brave · Jul 8, 2024 · 8dd42ab · 8dd42ab
1 parent 02249fe
commit 8dd42ab
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 15 deletions.
diff --git a/components/brave_wallet/browser/brave_wallet_prefs.cc b/components/brave_wallet/browser/brave_wallet_prefs.cc
@@ -54,9 +54,9 @@ constexpr char kBraveWalletUserAssetsAddIsSpamMigrated[] =
 constexpr char kBraveWalletUserAssetsAddIsERC1155Migrated[] =
     "brave.wallet.user.assets.add_is_erc1155_migrated";
 
-// Deprecated 05/2024
+// Deprecated 07/2024
 constexpr char kPinnedNFTAssetsMigrated[] = "brave.wallet.user_pin_data";
-// Deprecated 05/2024
+// Deprecated 07/2024
 constexpr char kAutoPinEnabledMigrated[] = "brave.wallet.auto_pin_enabled";
 
 base::Value::Dict GetDefaultSelectedNetworks() {

diff --git a/components/ipfs/ipfs_component_cleaner.cc b/components/ipfs/ipfs_component_cleaner.cc
@@ -31,10 +31,6 @@ static const base::FilePath::StringPieceType kIpfsClientComponentId =
 static const base::FilePath::StringPieceType kIpfsClientComponentId =
     FILE_PATH_LITERAL("oecghfpdmkjlhnfpmmjegjacfimiafjp");
 #endif
-#else
-// Not used yet for Android/iOS
-static const base::FilePath::StringPieceType kIpfsClientComponentId =
-    FILE_PATH_LITERAL("");
 #endif
 }  // namespace
 

diff --git a/components/ipfs/ipfs_utils.cc b/components/ipfs/ipfs_utils.cc
@@ -12,7 +12,6 @@
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "brave/components/filecoin/rs/src/lib.rs.h"
-#include "build/build_config.h"
 #include "components/base32/base32.h"
 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 #include "net/base/url_util.h"

diff --git a/ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+ToolbarDelegate.swift b/ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+ToolbarDelegate.swift
@@ -77,9 +77,9 @@ extension BrowserViewController: TopToolbarDelegate {
             showWeb3ServiceInterstitialPage(service: service, originalURL: url)
           case .load(let resolvedURL):
             if resolvedURL.isIPFSScheme,
-              let resolvedIPRSURL = braveCore.ipfsAPI.resolveGatewayUrl(for: resolvedURL)
+              let resolvedIPFSURL = braveCore.ipfsAPI.resolveGatewayUrl(for: resolvedURL)
             {
-              tabManager.selectedTab?.loadRequest(URLRequest(url: resolvedIPRSURL))
+              tabManager.selectedTab?.loadRequest(URLRequest(url: resolvedIPFSURL))
             } else {
               tabManager.selectedTab?.loadRequest(URLRequest(url: resolvedURL))
             }
@@ -282,9 +282,9 @@ extension BrowserViewController: TopToolbarDelegate {
           return true
         case .load(let resolvedURL):
           if resolvedURL.isIPFSScheme,
-            let resolvedIPRSURL = braveCore.ipfsAPI.resolveGatewayUrl(for: resolvedURL)
+            let resolvedIPFSURL = braveCore.ipfsAPI.resolveGatewayUrl(for: resolvedURL)
           {
-            finishEditingAndSubmit(resolvedIPRSURL)
+            finishEditingAndSubmit(resolvedIPFSURL)
           } else {
             finishEditingAndSubmit(resolvedURL)
           }

diff --git a/...e-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+WKNavigationDelegate.swift b/...e-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+WKNavigationDelegate.swift
@@ -279,9 +279,9 @@ extension BrowserViewController: WKNavigationDelegate {
         return (.cancel, preferences)
       case .load(let resolvedURL):
         if resolvedURL.isIPFSScheme,
-          let resolvedIPRSURL = braveCore.ipfsAPI.resolveGatewayUrl(for: resolvedURL)
+          let resolvedIPFSURL = braveCore.ipfsAPI.resolveGatewayUrl(for: resolvedURL)
         {
-          requestURL = resolvedIPRSURL
+          requestURL = resolvedIPFSURL
         } else {
           requestURL = resolvedURL
         }

diff --git a/ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+Web3NameService.swift b/ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+Web3NameService.swift
@@ -49,9 +49,9 @@ extension BrowserViewController: Web3NameServiceScriptHandlerDelegate {
       switch result {
       case .load(let resolvedURL):
         if resolvedURL.isIPFSScheme,
-          let resolvedIPRSURL = braveCore.ipfsAPI.resolveGatewayUrl(for: resolvedURL)
+          let resolvedIPFSURL = braveCore.ipfsAPI.resolveGatewayUrl(for: resolvedURL)
         {
-          finishEditingAndSubmit(resolvedIPRSURL)
+          finishEditingAndSubmit(resolvedIPFSURL)
         } else {
           finishEditingAndSubmit(resolvedURL)
         }