removed unneded ts test + several review suggestions

Signed-off-by: Vadym Struts <[email protected]>
brave · Jul 8, 2024 · 02249fe · 02249fe
1 parent 1d1d4d8
commit 02249fe
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 57 deletions.
diff --git a/components/brave_wallet_ui/common/async/base-query-cache.ts b/components/brave_wallet_ui/common/async/base-query-cache.ts
@@ -345,7 +345,7 @@ export class BaseQueryCache {
     }
     return token.logo.startsWith('ipfs://')
       ? (await this.getIpfsGatewayTranslatedNftUrl(token.logo)) || ''
-    : `chrome://erc-token-images/${token.logo}`
+      : `chrome://erc-token-images/${token.logo}`
   }
 
   getEnabledCoinTypes = async () => {

diff --git a/components/brave_wallet_ui/common/slices/endpoints/nfts.endpoints.ts b/components/brave_wallet_ui/common/slices/endpoints/nfts.endpoints.ts
@@ -287,4 +287,4 @@ export const nftsEndpoints = ({
       providesTags: ['SimpleHashSpamNFTs']
     })
   }
-}
+}
diff --git a/...rave_wallet_ui/components/shared/create-placeholder-icon/create_placeholder_icon.test.tsx b/...rave_wallet_ui/components/shared/create-placeholder-icon/create_placeholder_icon.test.tsx
diff --git a/components/brave_wallet_ui/components/shared/create-placeholder-icon/index.tsx b/components/brave_wallet_ui/components/shared/create-placeholder-icon/index.tsx
@@ -115,12 +115,19 @@ export function withPlaceholderIcon<
       }
     }, [needsPlaceholder, asset?.contractAddress, asset?.name])
 
+    const remoteImage = React.useMemo(() => {
+      if (isRemoteURL) {
+        return isStorybook ? tokenImageURL || '' : `chrome://image?${tokenImageURL}`
+      }
+      return ''
+    }, [isRemoteURL, tokenImageURL])
+
     // render
     if (!asset) {
       return null
     }
 
-    const icon = nativeAssetLogo || asset?.logo
+    const icon = nativeAssetLogo || (isRemoteURL ? remoteImage : asset?.logo)
 
     if (needsPlaceholder || !icon) {
       return (

diff --git a/components/brave_wallet_ui/components/shared/nft-icon/nft-icon.tsx b/components/brave_wallet_ui/components/shared/nft-icon/nft-icon.tsx
@@ -16,7 +16,7 @@ import {
 
 // hooks
 import {
-  useGetIpfsGatewayTranslatedNftUrlQuery
+  useGetIpfsGatewayTranslatedNftUrlQuery //
 } from '../../../common/slices/api.slice'
 
 // styles
-Original file line number
+Diff line change
@@ Expand Up / @@ -287,4 +287,4 @@ export const nftsEndpoints = ({ @@
           providesTags: ['SimpleHashSpamNFTs']
         })
       }
-    }
+    }