-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix entity does not exist message on index reuse #17264
Open
SpecificProtagonist
wants to merge
9
commits into
bevyengine:main
from
SpecificProtagonist:push-vzxrnylxuozx
Open
Fix entity does not exist message on index reuse #17264
SpecificProtagonist
wants to merge
9
commits into
bevyengine:main
from
SpecificProtagonist:push-vzxrnylxuozx
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecificProtagonist
added
C-Bug
An unexpected or incorrect behavior
A-ECS
Entities, components, systems, and events
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
labels
Jan 9, 2025
mockersf
reviewed
Jan 9, 2025
chescock
reviewed
Jan 10, 2025
SpecificProtagonist
force-pushed
the
push-vzxrnylxuozx
branch
from
January 10, 2025 21:43
e16f347
to
e21596e
Compare
SpecificProtagonist
force-pushed
the
push-vzxrnylxuozx
branch
from
January 10, 2025 21:58
b1c450b
to
2e894a0
Compare
chescock
approved these changes
Jan 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I left some style suggestions, but nothing blocking.
The test doesn't get run by CI, right? Maybe we should create an issue to run tests with the track_location
feature enabled. This probably won't be the last time we want tests for it!
BenjaminBrienen
approved these changes
Jan 11, 2025
BenjaminBrienen
added
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
and removed
S-Needs-Review
Needs reviewer attention (from anyone!) to move forward
labels
Jan 11, 2025
SpecificProtagonist
force-pushed
the
push-vzxrnylxuozx
branch
from
January 11, 2025 21:11
d30a104
to
e293aec
Compare
BenjaminBrienen
approved these changes
Jan 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-ECS
Entities, components, systems, and events
C-Bug
An unexpected or incorrect behavior
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
With the
track_location
feature, the error message of trying to acquire an entity that was despawned pointed to the wrong line if the entity index has been reused.Showcase
Old message:
New message: