Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable track_location tests #17314

Open
SpecificProtagonist opened this issue Jan 11, 2025 · 0 comments
Open

Enable track_location tests #17314

SpecificProtagonist opened this issue Jan 11, 2025 · 0 comments
Labels
A-Build-System Related to build systems or continuous integration C-Testing A change that impacts how we test Bevy or how users test their apps D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@SpecificProtagonist
Copy link
Contributor

What problem does this solve or what need does it fill?

There are two tests in bevy_ecs using the track_location feature, however bevy only runs tests with default features.

What solution would you like?

Enable the feature for bevy_ecs tests (but not benchmarks). Maybe make it clear which features are enabled for tests.

Additional context

#17264 (review)
@SpecificProtagonist SpecificProtagonist added C-Testing A change that impacts how we test Bevy or how users test their apps D-Trivial Nice and easy! A great choice to get started with Bevy labels Jan 11, 2025
@BenjaminBrienen BenjaminBrienen added S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! A-Build-System Related to build systems or continuous integration labels Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Testing A change that impacts how we test Bevy or how users test their apps D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SpecificProtagonist @BenjaminBrienen