Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DB/Gameobject): pooling and sniffed Values for 19018 'Giant Clam' spawns #21197

Merged
merged 3 commits into from
Jan 18, 2025

Conversation

sudlud
Copy link
Member

@sudlud sudlud commented Jan 17, 2025

pooling:

  • Eastern Kingdoms - Giant Clam - 10/32
  • Kalimdor - Giant Clam - 2/4
  • Blackfathom Deeps - Giant Clam - 12/27

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • NOT been tested

  • Tested in-game by the author.

  • Tested in-game by other community members/someone else other than the author/has been live on production servers.

  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@sudlud sudlud added Ready to be Reviewed DB Spawns Creature/Gameobject spawns labels Jan 17, 2025
@github-actions github-actions bot added the DB related to the SQL database label Jan 17, 2025
@TheSCREWEDSoftware
Copy link
Contributor

Going sonic speed in EK, Kalimdor and BFD i didn't count how many i encounter but i found a few in BFD (also is smaller was easier).

I pressume the 6/32 | 2/4 and 12/27 comments are 6 max can be active out of 32 ?

@TheSCREWEDSoftware TheSCREWEDSoftware added the Tested This PR has been tested and is working. label Jan 17, 2025
@sudlud
Copy link
Member Author

sudlud commented Jan 17, 2025

Going sonic speed in EK, Kalimdor and BFD i didn't count how many i encounter but i found a few in BFD (also is smaller was easier).

I pressume the 6/32 | 2/4 and 12/27 comments are 6 max can be active out of 32 ?

yes that's the setting of how many spawns of the pool should be active at the same time

@sudlud sudlud changed the title fix(DB/Gameobject): Sniffed Values for 'Giant Clam' spawns and pooling fix(DB/Gameobject): pooling and sniffed Values for 'Giant Clam' spawns Jan 17, 2025
@sudlud sudlud changed the title fix(DB/Gameobject): pooling and sniffed Values for 'Giant Clam' spawns fix(DB/Gameobject): pooling and sniffed Values for 19018 'Giant Clam' spawns Jan 18, 2025
@sudlud sudlud merged commit 818c03c into azerothcore:master Jan 18, 2025
12 checks passed
@sudlud sudlud deleted the gameobject-19018-1 branch January 18, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB Spawns Creature/Gameobject spawns DB related to the SQL database Ready to be Reviewed Tested This PR has been tested and is working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Giant Clam (19018)
2 participants