Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kubernetes-csi/external-snapshotter to v8.2.0; Remove Snapshot Validation Webhook #3458

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Bump kubernetes-csi/external-snapshotter to v8.2.0; Remove Snapshot Validation Webhook #3458

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
634294a
Bump kubernetes-csi/external-snapshotter to v8.2.0
AndrewSirenko Dec 10, 2024
2950eb1
Remove deprecated Snapshot Validation Webhook in external-snapshotter…
AndrewSirenko Dec 10, 2024
210da19
Update snapshotter GOLANG_VERSION
AndrewSirenko Dec 16, 2024
4041f40
Update checksums snapshotter
AndrewSirenko Dec 16, 2024
34ad127
fixup! Update checksums snapshotter
AndrewSirenko Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions development/ecr/image-docs/snapshot-validation-webhook-about.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
Amazon EKS Distro image for Kubernetes CSI External Snapshot Validation Webhook

Note: This webhook has deprecated by Kubernetes as of external-snapshotter v8.0.0, and removed as of v8.2.0. See https://github.com/kubernetes-csi/external-snapshotter/releases/tag/v8.2.0

The snapshot validating webhook is an HTTP callback which responds to admission requests. It provides tighter validation for volume snapshot objects. This webhook introduces the ratcheting validation mechanism that performs stricter validation. It should be installed alongside the snapshot controllers and CRDs.

https://github.com/kubernetes-csi/external-snapshotter
10 changes: 4 additions & 6 deletions projects/kubernetes-csi/external-snapshotter/1-27/CHECKSUMS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
5ca84eb92faf18b517511378c2012e108c8e1d6a109f05b53b5a7ada639c0591 _output/1-27/bin/external-snapshotter/linux-amd64/csi-snapshotter
ec0f13533329901f8f1d9422222d913c5fe56b744ce58c0063321efb73973550 _output/1-27/bin/external-snapshotter/linux-amd64/snapshot-controller
eaa5eed7c9cbc03a129148e86da4a3e5dd41a1959e15424de465e1743f4649aa _output/1-27/bin/external-snapshotter/linux-amd64/snapshot-validation-webhook
a805e11012c496289e4ca83ef4e3463b11ee6b308860f3a8e8111eb03895ced1 _output/1-27/bin/external-snapshotter/linux-arm64/csi-snapshotter
677c68d39daa022a8a9eacc3786fb85a0c537d988819d7e4058aa479dacf1a63 _output/1-27/bin/external-snapshotter/linux-arm64/snapshot-controller
d2d9025e4d24ef630b5dc8b71fa2d6f730e096438ec69bf77115181a5b80025a _output/1-27/bin/external-snapshotter/linux-arm64/snapshot-validation-webhook
3d1d5ed4b489a90131df5f3820834a14ff4b1412a94dbc57a4ddc93b0c5f2697 _output/1-27/bin/external-snapshotter/linux-amd64/csi-snapshotter
5bcec024f0edbfbf3a7717fc20eade52508ae8b99a6c859990083030dfb726f9 _output/1-27/bin/external-snapshotter/linux-amd64/snapshot-controller
c44d84691d2c8aac2c0ff781ab6ddb7dba44f05d70e3cd099a1d959c0d744f1e _output/1-27/bin/external-snapshotter/linux-arm64/csi-snapshotter
b5a95f54afd0a07f37db84bfebfac2dc48f630e01584c648410585ff5b212a2f _output/1-27/bin/external-snapshotter/linux-arm64/snapshot-controller
2 changes: 1 addition & 1 deletion projects/kubernetes-csi/external-snapshotter/1-27/GIT_TAG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v8.1.0
v8.2.0
2 changes: 1 addition & 1 deletion projects/kubernetes-csi/external-snapshotter/1-27/GOLANG_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.22
1.23
10 changes: 4 additions & 6 deletions projects/kubernetes-csi/external-snapshotter/1-28/CHECKSUMS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
cb9c89214a2cc552f1c37193e4c3bd7119a3d075f059c978480c9387fc90c7e5 _output/1-28/bin/external-snapshotter/linux-amd64/csi-snapshotter
105b126071f5fdfcb44d9f612e536dcb6a20d59d8455abf6a2a76394ba514e7c _output/1-28/bin/external-snapshotter/linux-amd64/snapshot-controller
7c2a825ac7bda0ea494517364d67c43e08a05054ee094fa7a99359f6efacc6b3 _output/1-28/bin/external-snapshotter/linux-amd64/snapshot-validation-webhook
ad0e4c0f4f1485e742ded2be24afc7033df6b17a278810d4975866ff300fc322 _output/1-28/bin/external-snapshotter/linux-arm64/csi-snapshotter
df602b9389f58811de11730602570d525c4420b194a8e36ad612515d06055a6b _output/1-28/bin/external-snapshotter/linux-arm64/snapshot-controller
e283c45297cb9931bd5549551293f6108e4570c5c4cc5b778a967c16477e44d5 _output/1-28/bin/external-snapshotter/linux-arm64/snapshot-validation-webhook
3d1d5ed4b489a90131df5f3820834a14ff4b1412a94dbc57a4ddc93b0c5f2697 _output/1-28/bin/external-snapshotter/linux-amd64/csi-snapshotter
5bcec024f0edbfbf3a7717fc20eade52508ae8b99a6c859990083030dfb726f9 _output/1-28/bin/external-snapshotter/linux-amd64/snapshot-controller
c44d84691d2c8aac2c0ff781ab6ddb7dba44f05d70e3cd099a1d959c0d744f1e _output/1-28/bin/external-snapshotter/linux-arm64/csi-snapshotter
b5a95f54afd0a07f37db84bfebfac2dc48f630e01584c648410585ff5b212a2f _output/1-28/bin/external-snapshotter/linux-arm64/snapshot-controller
2 changes: 1 addition & 1 deletion projects/kubernetes-csi/external-snapshotter/1-28/GIT_TAG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v8.1.0
v8.2.0
2 changes: 1 addition & 1 deletion projects/kubernetes-csi/external-snapshotter/1-28/GOLANG_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.22
1.23
10 changes: 4 additions & 6 deletions projects/kubernetes-csi/external-snapshotter/1-29/CHECKSUMS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
cb9c89214a2cc552f1c37193e4c3bd7119a3d075f059c978480c9387fc90c7e5 _output/1-29/bin/external-snapshotter/linux-amd64/csi-snapshotter
105b126071f5fdfcb44d9f612e536dcb6a20d59d8455abf6a2a76394ba514e7c _output/1-29/bin/external-snapshotter/linux-amd64/snapshot-controller
7c2a825ac7bda0ea494517364d67c43e08a05054ee094fa7a99359f6efacc6b3 _output/1-29/bin/external-snapshotter/linux-amd64/snapshot-validation-webhook
ad0e4c0f4f1485e742ded2be24afc7033df6b17a278810d4975866ff300fc322 _output/1-29/bin/external-snapshotter/linux-arm64/csi-snapshotter
df602b9389f58811de11730602570d525c4420b194a8e36ad612515d06055a6b _output/1-29/bin/external-snapshotter/linux-arm64/snapshot-controller
e283c45297cb9931bd5549551293f6108e4570c5c4cc5b778a967c16477e44d5 _output/1-29/bin/external-snapshotter/linux-arm64/snapshot-validation-webhook
3d1d5ed4b489a90131df5f3820834a14ff4b1412a94dbc57a4ddc93b0c5f2697 _output/1-29/bin/external-snapshotter/linux-amd64/csi-snapshotter
5bcec024f0edbfbf3a7717fc20eade52508ae8b99a6c859990083030dfb726f9 _output/1-29/bin/external-snapshotter/linux-amd64/snapshot-controller
c44d84691d2c8aac2c0ff781ab6ddb7dba44f05d70e3cd099a1d959c0d744f1e _output/1-29/bin/external-snapshotter/linux-arm64/csi-snapshotter
b5a95f54afd0a07f37db84bfebfac2dc48f630e01584c648410585ff5b212a2f _output/1-29/bin/external-snapshotter/linux-arm64/snapshot-controller
2 changes: 1 addition & 1 deletion projects/kubernetes-csi/external-snapshotter/1-29/GIT_TAG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v8.1.0
v8.2.0
2 changes: 1 addition & 1 deletion projects/kubernetes-csi/external-snapshotter/1-29/GOLANG_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.22
1.23
10 changes: 4 additions & 6 deletions projects/kubernetes-csi/external-snapshotter/1-30/CHECKSUMS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
cb9c89214a2cc552f1c37193e4c3bd7119a3d075f059c978480c9387fc90c7e5 _output/1-30/bin/external-snapshotter/linux-amd64/csi-snapshotter
105b126071f5fdfcb44d9f612e536dcb6a20d59d8455abf6a2a76394ba514e7c _output/1-30/bin/external-snapshotter/linux-amd64/snapshot-controller
7c2a825ac7bda0ea494517364d67c43e08a05054ee094fa7a99359f6efacc6b3 _output/1-30/bin/external-snapshotter/linux-amd64/snapshot-validation-webhook
ad0e4c0f4f1485e742ded2be24afc7033df6b17a278810d4975866ff300fc322 _output/1-30/bin/external-snapshotter/linux-arm64/csi-snapshotter
df602b9389f58811de11730602570d525c4420b194a8e36ad612515d06055a6b _output/1-30/bin/external-snapshotter/linux-arm64/snapshot-controller
e283c45297cb9931bd5549551293f6108e4570c5c4cc5b778a967c16477e44d5 _output/1-30/bin/external-snapshotter/linux-arm64/snapshot-validation-webhook
3d1d5ed4b489a90131df5f3820834a14ff4b1412a94dbc57a4ddc93b0c5f2697 _output/1-30/bin/external-snapshotter/linux-amd64/csi-snapshotter
5bcec024f0edbfbf3a7717fc20eade52508ae8b99a6c859990083030dfb726f9 _output/1-30/bin/external-snapshotter/linux-amd64/snapshot-controller
c44d84691d2c8aac2c0ff781ab6ddb7dba44f05d70e3cd099a1d959c0d744f1e _output/1-30/bin/external-snapshotter/linux-arm64/csi-snapshotter
b5a95f54afd0a07f37db84bfebfac2dc48f630e01584c648410585ff5b212a2f _output/1-30/bin/external-snapshotter/linux-arm64/snapshot-controller
2 changes: 1 addition & 1 deletion projects/kubernetes-csi/external-snapshotter/1-30/GIT_TAG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v8.1.0
v8.2.0
2 changes: 1 addition & 1 deletion projects/kubernetes-csi/external-snapshotter/1-30/GOLANG_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.22
1.23
10 changes: 4 additions & 6 deletions projects/kubernetes-csi/external-snapshotter/1-31/CHECKSUMS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
cb9c89214a2cc552f1c37193e4c3bd7119a3d075f059c978480c9387fc90c7e5 _output/1-31/bin/external-snapshotter/linux-amd64/csi-snapshotter
105b126071f5fdfcb44d9f612e536dcb6a20d59d8455abf6a2a76394ba514e7c _output/1-31/bin/external-snapshotter/linux-amd64/snapshot-controller
7c2a825ac7bda0ea494517364d67c43e08a05054ee094fa7a99359f6efacc6b3 _output/1-31/bin/external-snapshotter/linux-amd64/snapshot-validation-webhook
ad0e4c0f4f1485e742ded2be24afc7033df6b17a278810d4975866ff300fc322 _output/1-31/bin/external-snapshotter/linux-arm64/csi-snapshotter
df602b9389f58811de11730602570d525c4420b194a8e36ad612515d06055a6b _output/1-31/bin/external-snapshotter/linux-arm64/snapshot-controller
e283c45297cb9931bd5549551293f6108e4570c5c4cc5b778a967c16477e44d5 _output/1-31/bin/external-snapshotter/linux-arm64/snapshot-validation-webhook
3d1d5ed4b489a90131df5f3820834a14ff4b1412a94dbc57a4ddc93b0c5f2697 _output/1-31/bin/external-snapshotter/linux-amd64/csi-snapshotter
5bcec024f0edbfbf3a7717fc20eade52508ae8b99a6c859990083030dfb726f9 _output/1-31/bin/external-snapshotter/linux-amd64/snapshot-controller
c44d84691d2c8aac2c0ff781ab6ddb7dba44f05d70e3cd099a1d959c0d744f1e _output/1-31/bin/external-snapshotter/linux-arm64/csi-snapshotter
b5a95f54afd0a07f37db84bfebfac2dc48f630e01584c648410585ff5b212a2f _output/1-31/bin/external-snapshotter/linux-arm64/snapshot-controller
2 changes: 1 addition & 1 deletion projects/kubernetes-csi/external-snapshotter/1-31/GIT_TAG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v8.1.0
v8.2.0
2 changes: 1 addition & 1 deletion projects/kubernetes-csi/external-snapshotter/1-31/GOLANG_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.22
1.23
10 changes: 4 additions & 6 deletions projects/kubernetes-csi/external-snapshotter/1-32/CHECKSUMS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
cb9c89214a2cc552f1c37193e4c3bd7119a3d075f059c978480c9387fc90c7e5 _output/1-32/bin/external-snapshotter/linux-amd64/csi-snapshotter
105b126071f5fdfcb44d9f612e536dcb6a20d59d8455abf6a2a76394ba514e7c _output/1-32/bin/external-snapshotter/linux-amd64/snapshot-controller
7c2a825ac7bda0ea494517364d67c43e08a05054ee094fa7a99359f6efacc6b3 _output/1-32/bin/external-snapshotter/linux-amd64/snapshot-validation-webhook
ad0e4c0f4f1485e742ded2be24afc7033df6b17a278810d4975866ff300fc322 _output/1-32/bin/external-snapshotter/linux-arm64/csi-snapshotter
df602b9389f58811de11730602570d525c4420b194a8e36ad612515d06055a6b _output/1-32/bin/external-snapshotter/linux-arm64/snapshot-controller
e283c45297cb9931bd5549551293f6108e4570c5c4cc5b778a967c16477e44d5 _output/1-32/bin/external-snapshotter/linux-arm64/snapshot-validation-webhook
3d1d5ed4b489a90131df5f3820834a14ff4b1412a94dbc57a4ddc93b0c5f2697 _output/1-32/bin/external-snapshotter/linux-amd64/csi-snapshotter
5bcec024f0edbfbf3a7717fc20eade52508ae8b99a6c859990083030dfb726f9 _output/1-32/bin/external-snapshotter/linux-amd64/snapshot-controller
c44d84691d2c8aac2c0ff781ab6ddb7dba44f05d70e3cd099a1d959c0d744f1e _output/1-32/bin/external-snapshotter/linux-arm64/csi-snapshotter
b5a95f54afd0a07f37db84bfebfac2dc48f630e01584c648410585ff5b212a2f _output/1-32/bin/external-snapshotter/linux-arm64/snapshot-controller
2 changes: 1 addition & 1 deletion projects/kubernetes-csi/external-snapshotter/1-32/GIT_TAG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v8.1.0
v8.2.0
2 changes: 1 addition & 1 deletion projects/kubernetes-csi/external-snapshotter/1-32/GOLANG_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.22
1.23
10 changes: 3 additions & 7 deletions projects/kubernetes-csi/external-snapshotter/Help.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,23 +11,19 @@ clone-repo: ## Clone upstream `external-snapshotter`
checkout-repo: ## Checkout upstream tag based on value in GIT_TAG file

##@ Binary Targets
binaries: ## Build all binaries: `snapshot-controller csi-snapshotter snapshot-validation-webhook` for `linux/amd64 linux/arm64`
binaries: ## Build all binaries: `snapshot-controller csi-snapshotter` for `linux/amd64 linux/arm64`
_output/1-26/bin/external-snapshotter/linux-amd64/snapshot-controller: ## Build `_output/1-26/bin/external-snapshotter/linux-amd64/snapshot-controller`
_output/1-26/bin/external-snapshotter/linux-amd64/csi-snapshotter: ## Build `_output/1-26/bin/external-snapshotter/linux-amd64/csi-snapshotter`
_output/1-26/bin/external-snapshotter/linux-amd64/snapshot-validation-webhook: ## Build `_output/1-26/bin/external-snapshotter/linux-amd64/snapshot-validation-webhook`
_output/1-26/bin/external-snapshotter/linux-arm64/snapshot-controller: ## Build `_output/1-26/bin/external-snapshotter/linux-arm64/snapshot-controller`
_output/1-26/bin/external-snapshotter/linux-arm64/csi-snapshotter: ## Build `_output/1-26/bin/external-snapshotter/linux-arm64/csi-snapshotter`
_output/1-26/bin/external-snapshotter/linux-arm64/snapshot-validation-webhook: ## Build `_output/1-26/bin/external-snapshotter/linux-arm64/snapshot-validation-webhook`

##@ Image Targets
local-images: ## Builds `csi-snapshotter/images/amd64 snapshot-controller/images/amd64 snapshot-validation-webhook/images/amd64` as oci tars for presumbit validation
images: ## Pushes `csi-snapshotter/images/push snapshot-controller/images/push snapshot-validation-webhook/images/push` to IMAGE_REPO
local-images: ## Builds `csi-snapshotter/images/amd64 snapshot-controller/images/amd64` as oci tars for presumbit validation
images: ## Pushes `csi-snapshotter/images/push snapshot-controller/images/push` to IMAGE_REPO
csi-snapshotter/images/amd64: ## Builds/pushes `csi-snapshotter/images/amd64`
snapshot-controller/images/amd64: ## Builds/pushes `snapshot-controller/images/amd64`
snapshot-validation-webhook/images/amd64: ## Builds/pushes `snapshot-validation-webhook/images/amd64`
csi-snapshotter/images/push: ## Builds/pushes `csi-snapshotter/images/push`
snapshot-controller/images/push: ## Builds/pushes `snapshot-controller/images/push`
snapshot-validation-webhook/images/push: ## Builds/pushes `snapshot-validation-webhook/images/push`

##@ Checksum Targets
checksums: ## Update checksums file based on currently built binaries.
Expand Down
7 changes: 3 additions & 4 deletions projects/kubernetes-csi/external-snapshotter/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,13 @@ REPO_OWNER=kubernetes-csi

CSI_SNAPSHOTTER_IMAGE_COMPONENT?=kubernetes-csi/external-snapshotter/csi-snapshotter
SNAPSHOT_CONTROLLER_IMAGE_COMPONENT?=kubernetes-csi/external-snapshotter/snapshot-controller
SNAPSHOT_VALIDATION_WEBHOOK_IMAGE_COMPONENT?=kubernetes-csi/external-snapshotter/snapshot-validation-webhook

IMAGE_NAMES=csi-snapshotter snapshot-controller snapshot-validation-webhook
IMAGE_NAMES=csi-snapshotter snapshot-controller

SNAPSHOTTER_LICENSE=$(REPO)/vendor/github.com/kubernetes-csi/external-snapshotter/LICENSE

BINARY_TARGET_FILES=snapshot-controller csi-snapshotter snapshot-validation-webhook
SOURCE_PATTERNS=./cmd/snapshot-controller ./cmd/csi-snapshotter ./cmd/snapshot-validation-webhook
BINARY_TARGET_FILES=snapshot-controller csi-snapshotter
SOURCE_PATTERNS=./cmd/snapshot-controller ./cmd/csi-snapshotter

DOCKERFILE_FOLDER=./docker/linux/$(IMAGE_NAME)

Expand Down
6 changes: 3 additions & 3 deletions projects/kubernetes-csi/external-snapshotter/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

| Release | Version |
|---------|--------------------------------------------------------------|
| 1-28 | ![Version](https://img.shields.io/badge/version-v8.0.1-blue) |
| 1-29 | ![Version](https://img.shields.io/badge/version-v8.0.1-blue) |
| 1-30 | ![Version](https://img.shields.io/badge/version-v8.0.1-blue) |
| 1-29 | ![Version](https://img.shields.io/badge/version-v8.2.0-blue) |
| 1-30 | ![Version](https://img.shields.io/badge/version-v8.2.0-blue) |
| 1-31 | ![Version](https://img.shields.io/badge/version-v8.2.0-blue) |

### Updating

Expand Down
Loading