Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kubernetes-csi/external-snapshotter to v8.2.0; Remove Snapshot Validation Webhook #3458

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

AndrewSirenko
Copy link
Member

Issue #, if available:

Description of changes:

Bump kubernetes-csi/external-snapshotter to v8.2.0

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot added project Adds, Removes, or updates GIT_TAG in projects folder v1.29 v1.30 v1.31 v1.32 labels Dec 10, 2024
@AndrewSirenko
Copy link
Member Author

snapshot-validation-webhook-usage deprecated in external-snapshotter v8.2.0

I will update this PR tomorrow with the changes that this requires.

@AndrewSirenko AndrewSirenko marked this pull request as draft December 10, 2024 21:01
@AndrewSirenko AndrewSirenko marked this pull request as ready for review December 10, 2024 21:24
@AndrewSirenko AndrewSirenko changed the title Bump kubernetes-csi/external-snapshotter to v8.2.0 Bump kubernetes-csi/external-snapshotter to v8.2.0; Remove Snapshot Validation Webhook Dec 10, 2024
@AndrewSirenko AndrewSirenko marked this pull request as draft December 11, 2024 00:43
@AndrewSirenko AndrewSirenko marked this pull request as ready for review December 16, 2024 19:56
@AndrewSirenko
Copy link
Member Author

/retest

@AndrewSirenko
Copy link
Member Author

/retest

Looks like flake?

Buildkit daemon is not running. Retrying.
Buildkit daemon is not running. Retrying.
Buildkit daemon is not available
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"k8s.io/test-infra/prow/entrypoint/run.go:79","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"[20](https://prow.eks.amazonaws.com/view/s3/prowpresubmitsdataclusterstack-prowbucket7c73355c-vfwwxd2eb4gp/pr-logs/pull/aws_eks-distro/3458/external-snapshotter-1-27-presubmit/1868765811804475392#2:build-container-build-log.txt%3A20)24-12-16T21:14:42Z"}

@AndrewSirenko
Copy link
Member Author

/retest

@vineeth-bandi
Copy link
Member

/lgtm

@vineeth-bandi
Copy link
Member

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vineeth-bandi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 1a34856 into aws:main Dec 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants