Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix the flaky domain tests, from the log of the previous failed CI test there are 2 cases that cause the test to fail:
#37
, this may be due to there is a 500 microsecond timeout limit to get tx from the pool, and the timeout may be passed due to kernel interrupt before getting the tx, this PR fix it by removing the timeout limit in the test.confirm_acknowledgement
returning early before the slot notification is finished processed:It is suspected cause by smol-rs/async-channel#54, this PR try to use the
future::channel
workaround the issue.Code contributor checklist: