Fix flaky domain test by adding more retries for producing bundle in test #2517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NingLin-P
requested review from
vedhavyas,
nazar-pc and
rg3l3dr
as code owners
Signed-off-by: linning <[email protected]>
NingLin-P
force-pushed
the
fix-ci-test
branch
from
e33c78c to
f9fa7b8
Compare
vedhavyas
reviewed
Feb 13, 2024
| @@ -170,8 +170,7 @@ async fn benchmark_bundle_with_evm_tx( | |||
| const TX_TYPES: u32 = 4; | |||
| let mut thread_rng = rand::thread_rng(); | |||
| let between = Uniform::from(0..TX_TYPES); | |||
| let (slot, bundle) = ferdie.produce_slot_and_wait_for_bundle_submission().await; | |||
| assert!(bundle.is_some()); | |||
There was a problem hiding this comment.
confused with this change. Dont we want to ensure the bundle is submitted anyway?
There was a problem hiding this comment.
Yeah, but produce_slot_and_wait_for_bundle_submission will panic instead if bundle is not submitted after a few tries, so we don't need the assert here.
vedhavyas
previously approved these changes
Feb 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
nazar-pc
approved these changes
Feb 16, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to fix the flaky domain tests in CI.
After #2220 it seems still possible for bundle production to fail due to race condition. Instead of strictly requiring bundle production to succeed, this PR simply adds more retry, it should mitigate most of the failure since the failure is not very frequent in CI.
The only notable change is in the
subspace-test-service, all other changes are just adjustments for the test infra API change.Code contributor checklist: