Fix saving unsaved data in finish workflow action #10157 #10158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression in 7cccf96 (unreleased).
chrabyrd
requested changes
Oct 20, 2023
Comment on lines
441
to
443
| self.activeStep().save().then(function() { | ||
| self.markWorkflowComplete(); | ||
| }); |
There was a problem hiding this comment.
nit: this can be reduced to self.activeStep().save().then(self.markWorkflowComplete)
Comment on lines
444
to
446
| return; | ||
| } | ||
| self.markWorkflowComplete(); |
There was a problem hiding this comment.
nit ( since we're refactoring ): replacing the return statement with if/else logic is slightly more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description of Change
7cccf96 relied on a recursive call to
self.finishWorkflow()to handle marking the workflow as complete, but besides theTypeErrorfrom usingthisinstead ofself, it was also executing a bunch of unnecessary requests instead of only sending one POST for the unsaved data and one POST for marking complete. Extracted a new function to mitigate that.Issues Solved
Closes #10157