Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[workflows] this.finishWorkflow is not a function #10157

Closed
jacobtylerwalls opened this issue Oct 19, 2023 · 1 comment · Fixed by #10158
Closed

[workflows] this.finishWorkflow is not a function #10157

jacobtylerwalls opened this issue Oct 19, 2023 · 1 comment · Fixed by #10158
Assignees
@jacobtylerwalls
Labels
bug

Comments

@jacobtylerwalls
Copy link
Member

Advance to a workflow step that allows you to have unsaved data and a Save and Complete Workflow action, such as: AfS X/Y Upload Workflow > File Interpretation step.

Click Save and Complete Workflow.

Result:

Uncaught (in promise) TypeError: this.finishWorkflow is not a function

Regression in 7cccf96 (unreleased)
@jacobtylerwalls jacobtylerwalls self-assigned this Oct 19, 2023
@chiatt chiatt added this to pipeline Oct 19, 2023
@jacobtylerwalls jacobtylerwalls moved this to 🏗 In Progress in pipeline Oct 19, 2023
@jacobtylerwalls jacobtylerwalls moved this to 🏗 In progress in afs-pipeline Oct 19, 2023
jacobtylerwalls added a commit that referenced this issue Oct 19, 2023
@jacobtylerwalls
Fix TypeError in finish workflow action #10157
849c9ca 
Regression in 7cccf96 (unreleased).
jacobtylerwalls added a commit that referenced this issue Oct 19, 2023
@jacobtylerwalls
Fix saving unsaved data in finish workflow action #10157
90882bc
jacobtylerwalls added a commit that referenced this issue Oct 19, 2023
@jacobtylerwalls
Fix saving unsaved data in finish workflow action #10157
c4259d6 
Regression in 7cccf96 (unreleased).
@jacobtylerwalls jacobtylerwalls mentioned this issue Oct 19, 2023
Merged
3 tasks
@jacobtylerwalls jacobtylerwalls linked a pull request Oct 19, 2023 that will close this issue
Fix saving unsaved data in finish workflow action #10157 #10158
Merged
3 tasks
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In progress to 👀 In review in afs-pipeline Oct 19, 2023
@jacobtylerwalls jacobtylerwalls moved this from 🏗 In Progress to 👀 In Review in pipeline Oct 19, 2023
jacobtylerwalls added a commit that referenced this issue Oct 20, 2023
@jacobtylerwalls
nit re #10157
f082f18
chrabyrd added a commit that referenced this issue Oct 23, 2023
@chrabyrd
Merge pull request #10158 from archesproject/10157-finish-workflow
0d310ad 
Fix saving unsaved data in finish workflow action #10157
@chrabyrd
Copy link
Contributor

resolved in #10158

@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in pipeline Oct 23, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in afs-pipeline Oct 23, 2023
@jacobtylerwalls jacobtylerwalls mentioned this issue Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacobtylerwalls jacobtylerwalls

Labels
bug
Projects
afs-pipeline
Status: ✅ Done
pipeline
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix saving unsaved data in finish workflow action #10157 archesproject/arches
2 participants
@chrabyrd @jacobtylerwalls