fix bugs explain with non-correlated query #13210
Conversation
github-actions
bot
added
physical-expr
| .push(StringifiedPlan::new(InitialPhysicalPlan, e.to_string())), | ||
| Err(err) => { | ||
| return Ok(Some(Arc::new(ExplainExec::new( | ||
| SchemaRef::new(Schema::new(vec
There was a problem hiding this comment.
I think this change means that the explain will not have the logical plan, but instead will have only the error message for creating the physical plan as the "Final Logical Plan"
|
I merged up from main to try and get the CI passing (I won't force push this PR again!) |
| @@ -1797,11 +1797,19 @@ impl DefaultPhysicalPlanner { | |||
| Err(e) => return Err(e), | |||
| } | |||
| } | |||
| Err(e) => stringified_plans | |||
| .push(StringifiedPlan::new(InitialPhysicalPlan, e.to_string())), | |||
There was a problem hiding this comment.
I played around with this some more this morning -- I think the reason the error isn't displayed is that InitialPhysicalPlan is not shown by default in explain plans.
There was a problem hiding this comment.
Thank you @Lordworms -- I played around with this and I think I found another way to do it:
Let me know what you think!
Use explicit enum for physical errors
github-actions
bot
added
common
Thanks a lot! |
Which issue does this PR close?
Closes #5265
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?