-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bugs explain with non-correlated query #13210
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
95e635f
fix bugs explain with non-correlated query
Lordworms 8001eed
Merge remote-tracking branch 'apache/main' into issue_5265
alamb 29252e3
Use explicit enum for physical errors
alamb 0b6f498
fix comments / fmt
alamb 82d9560
Merge pull request #2 from alamb/alamb/improved_error_plan
Lordworms 3dd7a48
strip_backtrace to passs ci
Lordworms File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
Loading status checks…
fix bugs explain with non-correlated query
- Loading branch information
commit 95e635fee7ecd8b47f735fca7b11ae2e17d81f86
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1792,11 +1792,19 @@ impl DefaultPhysicalPlanner { | |
Err(e) => return Err(e), | ||
} | ||
} | ||
Err(e) => stringified_plans | ||
.push(StringifiedPlan::new(InitialPhysicalPlan, e.to_string())), | ||
Err(err) => { | ||
return Ok(Some(Arc::new(ExplainExec::new( | ||
SchemaRef::new(Schema::new(vec![arrow_schema::Field::new( | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this change means that the explain will not have the logical plan, but instead will have only the error message for creating the physical plan as the "Final Logical Plan" |
||
"Err", | ||
arrow_schema::DataType::Utf8, | ||
false, | ||
)])), | ||
vec![StringifiedPlan::new(FinalLogicalPlan, err.to_string())], | ||
e.verbose, | ||
)))) | ||
} | ||
} | ||
} | ||
|
||
Ok(Some(Arc::new(ExplainExec::new( | ||
SchemaRef::new(e.schema.as_ref().to_owned().into()), | ||
stringified_plans, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I played around with this some more this morning -- I think the reason the error isn't displayed is that
InitialPhysicalPlan
is not shown by default in explain plans.