-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix bugs for explain supporting non-correlated subquery #13116
Conversation
@@ -134,6 +134,9 @@ async fn test_count_wildcard_on_where_in() -> Result<()> { | |||
Ok(()) | |||
} | |||
|
|||
/// this should return Err: Physical plan does not support | |||
/// logical expression Exists ignore for now | |||
#[ignore] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a regression? I don't understand why this test is disabled.
This test appears to have been added in #6010
I had it checked out to play around with it and got the test to work again by only explaining the logical plan.
I pushed to this branch -- hope that is ok
I am sorry @Lordworms and @Dandandan - I messed up this PR -- I accidentally force pushed the branch without any code commits and that caused github to close the PR 😢 This commit needs to be cherry-picked and then the branch repushed git cherry-pick b0758c059 I pushed it to my fork here: alamb@b0758c059 in case that is helpful I can also open a new PR with the same change |
What I was trying to do was avoid the changes in the tests Rather than percolating the error out and failing the |
I think that would be better, Thanks a lot. I'll change it into the error message. |
Again I am really sorry. To confirm, you plan to open another PR, or would you like me to do so? |
Don't worry, it is fine :)
I can do that |
New PR: #13210 |
Which issue does this PR close?
Closes #5265
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?