Skip to content
NodeJS

GH-45250: [JS] Fix denominator precision loss and remove unnecessary safe integer check for fractional part #2937

Sign in to view logs

GH-45250: [JS] Fix denominator precision loss and remove unnecessary safe integer check for fractional part

GH-45250: [JS] Fix denominator precision loss and remove unnecessary safe integer check for fractional part #2937

Triggered via pull request January 15, 2025 11:12
@yaooqinnyaooqinn
synchronize #45251
yaooqinn:bignum
Status Success
Total duration 43m 11s
Artifacts –

js.yml

on: pull_request
AMD64 Debian 12 NodeJS 18
21m 33s
AMD64 Debian 12 NodeJS 18
Matrix: macos
Matrix: windows
Fit to window
Zoom out
Zoom in

Annotations

33 warnings
AMD64 Debian 12 NodeJS 18
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
AMD64 Windows NodeJS 18: build/js/src/util/buffer.ts#L134
Move generator function 'wrap' to the outer scope
AMD64 Windows NodeJS 18: build/js/src/util/buffer.ts#L172
Move async generator function 'wrap' to the outer scope
AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L325
Unnecessarily cloning an array
AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L347
Unnecessarily cloning an array
AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L368
Unnecessarily cloning an array
AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L378
Unnecessarily cloning an array
AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L486
Unnecessarily cloning an array
AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L624
Unnecessarily cloning an array
AMD64 Windows NodeJS 18: build/js/src/util/buffer.ts#L134
Move generator function 'wrap' to the outer scope
AMD64 Windows NodeJS 18: build/js/src/util/buffer.ts#L172
Move async generator function 'wrap' to the outer scope
AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L325
Unnecessarily cloning an array
AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L347
Unnecessarily cloning an array
AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L368
Unnecessarily cloning an array
AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L378
Unnecessarily cloning an array
AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L486
Unnecessarily cloning an array
AMD64 Windows NodeJS 18: build/js/test/generate-test-data.ts#L624
Unnecessarily cloning an array
AMD64 macOS 13 NodeJS 18: build/js/src/util/buffer.ts#L134
Move generator function 'wrap' to the outer scope
AMD64 macOS 13 NodeJS 18: build/js/src/util/buffer.ts#L172
Move async generator function 'wrap' to the outer scope
AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L325
Unnecessarily cloning an array
AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L347
Unnecessarily cloning an array
AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L368
Unnecessarily cloning an array
AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L378
Unnecessarily cloning an array
AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L486
Unnecessarily cloning an array
AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L624
Unnecessarily cloning an array
AMD64 macOS 13 NodeJS 18: build/js/src/util/buffer.ts#L134
Move generator function 'wrap' to the outer scope
AMD64 macOS 13 NodeJS 18: build/js/src/util/buffer.ts#L172
Move async generator function 'wrap' to the outer scope
AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L325
Unnecessarily cloning an array
AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L347
Unnecessarily cloning an array
AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L368
Unnecessarily cloning an array
AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L378
Unnecessarily cloning an array
AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L486
Unnecessarily cloning an array
AMD64 macOS 13 NodeJS 18: build/js/test/generate-test-data.ts#L624
Unnecessarily cloning an array