-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45250: [JS] Fix denominator precision loss and remove unnecessary safe integer check for fractional part #45251
Conversation
…eck for fractional part
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format?
or
See also: |
…eck for fractional part
…eck for fractional part
…eck for fractional part
|
Co-authored-by: Paul Taylor <[email protected]>
Co-authored-by: Paul Taylor <[email protected]>
Co-authored-by: Paul Taylor <[email protected]>
Co-authored-by: Paul Taylor <[email protected]>
Co-authored-by: Paul Taylor <[email protected]>
Thank you @trxcllnt for the suggestion and approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit f8f17a5. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 20 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
What changes are included in this PR?
This PR uses string constructor for bigint to calculate the power of 10 with scale as the exponent value of the expression.
To Fix precision loss like
Also, we remove the unnecessary safe integer check for the fraction part.
Are these changes tested?
add some unit tests
Are there any user-facing changes?
no