Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TECH-132: [alleyvate] Limit access to XML-RPC #50 #114

Merged
merged 20 commits into from
Nov 6, 2024

Conversation

jakewrfoster
Copy link
Member

@jakewrfoster jakewrfoster commented Oct 21, 2024

Summary

[alleyvate] Limit access to XML-RPC from Jetpack IPs only #50 - TECH-132

Notes for reviewers

Please review the changes in the context of limiting access to XML-RPC as described in the GitHub Issue.

Before merging, see #115, which blocks this item.
IF THIS IS MERGED INTO A RELEASE WITHOUT #115, IT WILL TRIGGER A FATAL ERROR.

Other Information

  • I updated the README.md file for any new/updated features.
  • I updated the CHANGELOG.md file for any new/updated features.

Changelog entries

Added

Changed

  • Limited access to XML-RPC to enhance security and performance.

Deprecated

Removed

Fixed

Security

  • Limited access to XML-RPC to prevent unauthorized access.

@@ -21,7 +21,8 @@
"require": {
"php": "^8.1",
"alleyinteractive/composer-wordpress-autoloader": "^1.0",
"alleyinteractive/wp-type-extensions": "^2.0"
"alleyinteractive/wp-type-extensions": "^2.0",
"symfony/http-foundation": "^v6.4.12"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest version compatible with mantle testkit.

@jakewrfoster
Copy link
Member Author

Before merging, see #115, which blocks this item.
IF THIS IS MERGED INTO A RELEASE WITHOUT #115, IT WILL TRIGGER A FATAL ERROR.

@jakewrfoster jakewrfoster marked this pull request as ready for review October 23, 2024 18:42
@jakewrfoster jakewrfoster requested a review from a team as a code owner October 23, 2024 18:42
Copy link
Contributor

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@mogmarsh mogmarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Just found a couple comments that need updating in the test file. 👍

tests/Alley/WP/Alleyvate/Features/DisableXMLRPCTest.php Outdated Show resolved Hide resolved
tests/Alley/WP/Alleyvate/Features/DisableXMLRPCTest.php Outdated Show resolved Hide resolved
@jakewrfoster jakewrfoster merged commit 3f53974 into main Nov 6, 2024
6 checks passed
@jakewrfoster jakewrfoster deleted the feature/TECH-132/limit-access-to-xml-rpc branch November 6, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants