Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build composer dependencies for releases #115

Closed
jakewrfoster opened this issue Oct 21, 2024 · 2 comments
Closed

Build composer dependencies for releases #115

jakewrfoster opened this issue Oct 21, 2024 · 2 comments
Assignees
@jakewrfoster
Labels
ci/cd PR checks, deploys, automation enhancement New feature or request php Requires understanding PHP

Comments

@jakewrfoster
Copy link
Member

Description

Future features may rely on built third-party composer dependencies. Currently there are no vendor file associated with the builds. #114, for example, relies on such dependencies.

Use Case

Releases should include third-party composer dependencies, so that future features that depend on them will work with future releases.
@jakewrfoster jakewrfoster added the enhancement New feature or request label Oct 21, 2024
@jakewrfoster
Copy link
Member Author

This is currently blocking #114

@jakewrfoster jakewrfoster mentioned this issue Oct 23, 2024
Merged
2 tasks
@jakewrfoster jakewrfoster self-assigned this Oct 23, 2024
@jakewrfoster
Copy link
Member Author

a package.json should be added with an engines directive and a scripts directive. The following release scripts should be included: https://github.com/alleyinteractive/create-wordpress-plugin/blob/develop/package.json#L34

@jakewrfoster jakewrfoster mentioned this issue Nov 5, 2024
Merged
2 tasks
@kevinfodness kevinfodness added ci/cd PR checks, deploys, automation php Requires understanding PHP labels Nov 11, 2024
@srtfisher srtfisher mentioned this issue Dec 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakewrfoster jakewrfoster

Labels
ci/cd PR checks, deploys, automation enhancement New feature or request php Requires understanding PHP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakewrfoster @kevinfodness