Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/259 incorrect scope code written to iso #300

Closed

Conversation

jwaspin
Copy link
Contributor

@jwaspin jwaspin commented Nov 9, 2023

This is now part of the releases/2-18-4 branch

This PR can be merged if it's desired to only add this part of the release branch, otherwise it will be closed when that branch has been merged.

Changes

  • Remove hardcoded series value.
  • Replace with retrieved value from hDataQuality.

Testing

http://23.23.4.125:3001/

Remove hardcoded series value.
Replace with retrieved value from hDataQuality.
@jwaspin jwaspin linked an issue Nov 9, 2023 that may be closed by this pull request
@jwaspin jwaspin requested a review from hmaier-fws November 9, 2023 18:33
@jwaspin jwaspin marked this pull request as draft November 16, 2023 16:05
@jwaspin jwaspin mentioned this pull request Nov 16, 2023
Copy link

@hmaier-fws hmaier-fws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to make sense...

@hmaier-fws
Copy link

Closing as PR #308 indicates that it replaces this one.

@hmaier-fws hmaier-fws closed this Nov 27, 2023
@jwaspin jwaspin deleted the bugfix/259-incorrect-scope-code-written-to-iso branch December 8, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants