Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Scope Code Written to ISO #259

Closed
dwalt opened this issue Aug 23, 2023 · 4 comments · Fixed by #308
Closed

Incorrect Scope Code Written to ISO #259

dwalt opened this issue Aug 23, 2023 · 4 comments · Fixed by #308
Assignees
Labels

Comments

@dwalt
Copy link
Collaborator

dwalt commented Aug 23, 2023

-1 and -2 writers are writing a "dataset" Scope Code as "series". Problem noticed in Data Quality, not checked in other Scope Code usage.

@dwalt dwalt added bug Unexpected problem or unintended behavior writer:iso19115_2 writer:iso19115_1 writer:iso19110 labels Aug 23, 2023
@dwalt dwalt changed the title Conversion of Deprecated geographicDataset Scope Code Incorrect Scope Code Written to ISO Aug 26, 2023
@jwaspin jwaspin self-assigned this Sep 18, 2023
@jwaspin
Copy link
Contributor

jwaspin commented Oct 23, 2023

Looks like I found the problem in the file lib/adiwg/mdtranslator/writers/iso19115_1/classes/class_dataQuality.rb

@xml.tag!('mdq:scope') do
  @xml.tag!('mcc:MD_Scope') do
    @xml.tag!('mcc:level') do
      @xml.tag!('mcc:MD_ScopeCode', codeList: "http://www.isotc211.org/2005/resources/Codelist/gmxCodelists.xml#MD_ScopeCode", codeListValue: "series")
    end
  end
end

@jwaspin
Copy link
Contributor

jwaspin commented Nov 8, 2023

@dwalt

<mdb:dataQualityInfo>
      <mdq:DQ_DataQuality>
         <mdq:scope>
            <mcc:MD_Scope>
               <mcc:level>
                  <mcc:MD_ScopeCode codeList="http://www.isotc211.org/2005/resources/Codelist/gmxCodelists.xml#MD_ScopeCode" codeListValue="series"/>
               </mcc:level>
            </mcc:MD_Scope>
         </mdq:scope>
      </mdq:DQ_DataQuality>
   </mdb:dataQualityInfo>

Is the issue just with the codeListValue? Or is that URL also wrong?

@dwalt
Copy link
Collaborator Author

dwalt commented Nov 8, 2023

No, the value is valid, but it is not what I selected from the drop-down list in the UI.

@jwaspin
Copy link
Contributor

jwaspin commented Nov 9, 2023

Sorry wrong word, meant to say incorrect as opposed to invalid. As long as it's just the value that doesn't match up with the selection from the drop-down then I think I should have this resolved in the morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants