Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge upstream 2 #306

Merged
merged 23 commits into from
Jan 17, 2025

Merge branch 'master' into oss-merge

9d04e2a
Select commit
Loading
Failed to load commit list.
Merged

merge upstream 2 #306

Merge branch 'master' into oss-merge
9d04e2a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2025 in 0s

60.48% (target 0.00%)

View this Pull Request on Codecov

60.48% (target 0.00%)

Details

Codecov Report

Attention: Patch coverage is 60.99291% with 55 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ners/profile/sidebar/Ownership/EditOwnersModal.tsx 0.00% 19 Missing ⚠️
metadata-ingestion/src/datahub/cli/ingest_cli.py 0.00% 12 Missing ⚠️
...ingestion/source/gc/soft_deleted_entity_cleanup.py 9.09% 10 Missing ⚠️
datahub-web-react/src/app/shared/OwnerLabel.tsx 40.00% 6 Missing ⚠️
...stion/src/datahub/secret/datahub_secrets_client.py 0.00% 4 Missing ⚠️
...ion/source/powerbi/rest_api_wrapper/powerbi_api.py 66.66% 2 Missing ⚠️
...ty/shared/containers/profile/header/EntityName.tsx 0.00% 1 Missing ⚠️
metadata-ingestion/src/datahub/entrypoints.py 50.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...ub-web-react/src/app/context/CustomUserContext.tsx 100.00% <100.00%> (ø)
datahub-web-react/src/app/context/userContext.tsx 100.00% <100.00%> (ø)
...ion/src/datahub/ingestion/source/datahub/config.py 82.05% <ø> (ø)
...tion/src/datahub/ingestion/source/gc/datahub_gc.py 0.00% <ø> (ø)
...n/src/datahub/ingestion/source/ge_data_profiler.py 72.12% <100.00%> (+0.15%) ⬆️
...ata-ingestion/src/datahub/ingestion/source/mode.py 86.08% <ø> (ø)
...tion/src/datahub/ingestion/source/sql/sql_types.py 78.46% <ø> (ø)
...on/src/datahub/ingestion/source/tableau/tableau.py 89.11% <100.00%> (+0.37%) ⬆️
...datahub/ingestion/source/tableau/tableau_common.py 92.71% <100.00%> (+1.05%) ⬆️
.../src/datahub/sql_parsing/sql_parsing_aggregator.py 93.90% <100.00%> (+0.01%) ⬆️
... and 12 more

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d71e50...9d04e2a. Read the comment docs.

View more details on Codecov