Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge upstream 2 #306

Merged
merged 23 commits into from
Jan 17, 2025
Merged

merge upstream 2 #306

merged 23 commits into from
Jan 17, 2025

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Jan 17, 2025

Replaces #305

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

hsheth2 and others added 23 commits January 15, 2025 10:59
Copy link

Hello @hsheth2 😄

Thank you so much for opening a pull request!

Image
You can check out your contributor card and see all your past stats here!

@hsheth2 hsheth2 mentioned this pull request Jan 17, 2025
5 tasks
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 60.99291% with 55 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ners/profile/sidebar/Ownership/EditOwnersModal.tsx 0.00% 19 Missing ⚠️
metadata-ingestion/src/datahub/cli/ingest_cli.py 0.00% 12 Missing ⚠️
...ingestion/source/gc/soft_deleted_entity_cleanup.py 9.09% 10 Missing ⚠️
datahub-web-react/src/app/shared/OwnerLabel.tsx 40.00% 6 Missing ⚠️
...stion/src/datahub/secret/datahub_secrets_client.py 0.00% 4 Missing ⚠️
...ion/source/powerbi/rest_api_wrapper/powerbi_api.py 66.66% 2 Missing ⚠️
...ty/shared/containers/profile/header/EntityName.tsx 0.00% 1 Missing ⚠️
metadata-ingestion/src/datahub/entrypoints.py 50.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...ub-web-react/src/app/context/CustomUserContext.tsx 100.00% <100.00%> (ø)
datahub-web-react/src/app/context/userContext.tsx 100.00% <100.00%> (ø)
...ion/src/datahub/ingestion/source/datahub/config.py 82.05% <ø> (ø)
...tion/src/datahub/ingestion/source/gc/datahub_gc.py 0.00% <ø> (ø)
...n/src/datahub/ingestion/source/ge_data_profiler.py 72.12% <100.00%> (+0.15%) ⬆️
...ata-ingestion/src/datahub/ingestion/source/mode.py 86.08% <ø> (ø)
...tion/src/datahub/ingestion/source/sql/sql_types.py 78.46% <ø> (ø)
...on/src/datahub/ingestion/source/tableau/tableau.py 89.11% <100.00%> (+0.37%) ⬆️
...datahub/ingestion/source/tableau/tableau_common.py 92.71% <100.00%> (+1.05%) ⬆️
.../src/datahub/sql_parsing/sql_parsing_aggregator.py 93.90% <100.00%> (+0.01%) ⬆️
... and 12 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d71e50...9d04e2a. Read the comment docs.

@yoonhyejin yoonhyejin self-requested a review January 17, 2025 06:33
@hsheth2 hsheth2 merged commit 9d34988 into master Jan 17, 2025
155 of 160 checks passed
@hsheth2 hsheth2 deleted the oss-merge branch January 17, 2025 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.