Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factorize get subject session #1190

Merged

Conversation

maximemulder
Copy link
Contributor

@maximemulder maximemulder commented Sep 27, 2024

This PR extracts the "get subject session" operation out of BasePipeline, with the goal of making it easily reusable by all scripts, including those that do not use BasePipeline (new DICOM archive and eventually BIDS import). It also modernizes the database access by using the new SQLAlchemy abstractions.

Is depended on by:

@maximemulder maximemulder force-pushed the 2024-09-26_factorize-subject-session branch from c1aab1f to 917e939 Compare September 27, 2024 16:32
@maximemulder maximemulder added the S-Medium Size: Medium. Moderately-sized pull requests that are not too complex but not trivial either label Oct 4, 2024
@maximemulder maximemulder force-pushed the 2024-09-26_factorize-subject-session branch 2 times, most recently from 234d5e6 to 4342e78 Compare October 17, 2024 19:30
@maximemulder maximemulder self-assigned this Nov 19, 2024
@maximemulder maximemulder force-pushed the 2024-09-26_factorize-subject-session branch 3 times, most recently from 8a46f76 to b9d5c66 Compare December 22, 2024 01:04
@maximemulder maximemulder force-pushed the 2024-09-26_factorize-subject-session branch 4 times, most recently from 835840d to 7605a83 Compare December 22, 2024 03:48
@maximemulder maximemulder marked this pull request as ready for review December 22, 2024 03:53
@maximemulder maximemulder requested a review from cmadjar December 22, 2024 03:53
@maximemulder maximemulder force-pushed the 2024-09-26_factorize-subject-session branch from 7605a83 to 5f80dbe Compare December 22, 2024 04:02
@maximemulder maximemulder force-pushed the 2024-09-26_factorize-subject-session branch from 5f80dbe to 9c5c10e Compare December 23, 2024 00:32
@maximemulder maximemulder added the A-ORM Area: ORM. Issues and pull requests related to the SQLAlchemy integration label Dec 23, 2024
@maximemulder
Copy link
Contributor Author

Considering the following:

  1. SQLAlchemy model integration test
  2. DICOM to BIDS integration test
  3. This PR is straightforward
  4. My careful self-review

I'll merge this once CI is green.

@maximemulder maximemulder merged commit e0a80c9 into aces:main Dec 24, 2024
9 checks passed
@maximemulder maximemulder deleted the 2024-09-26_factorize-subject-session branch December 24, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ORM Area: ORM. Issues and pull requests related to the SQLAlchemy integration S-Medium Size: Medium. Moderately-sized pull requests that are not too complex but not trivial either
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant