Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate "get all sites from the database" to the SQLAlchemy abstraction #1216

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

maximemulder
Copy link
Contributor

@maximemulder maximemulder commented Dec 23, 2024

Depends on #1190
Is depended on by #1211

Migrate "get all sites from the database" to the SQLAlchemy abstraction. I'd like to use the same function in the incremental BIDS import. This PR also deprecate a few functions that already have alternatives in the SQLAlchemy abstraction.

@maximemulder maximemulder added S-Small Size: Small. Simple pull requests that contain little code and should be easy to review A-ORM Area: ORM. Issues and pull requests related to the SQLAlchemy integration Blocked Merge it and you die labels Dec 23, 2024
@maximemulder maximemulder changed the title Migreate "get all sites from the database" to the SQLAlchemy abstraction Migrate "get all sites from the database" to the SQLAlchemy abstraction Dec 23, 2024
@maximemulder maximemulder force-pushed the 2024-09-03_sqlalchemy-site branch from 08c1a4a to 88714f0 Compare December 23, 2024 01:10
@maximemulder maximemulder force-pushed the 2024-09-03_sqlalchemy-site branch from 88714f0 to ad8a0fc Compare December 24, 2024 04:01
@maximemulder
Copy link
Contributor Author

maximemulder commented Dec 24, 2024

Same reasoning as #1190

@maximemulder maximemulder merged commit afde18f into aces:main Dec 24, 2024
9 checks passed
@maximemulder maximemulder deleted the 2024-09-03_sqlalchemy-site branch December 24, 2024 04:07
@cmadjar cmadjar added this to the 27.0 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ORM Area: ORM. Issues and pull requests related to the SQLAlchemy integration Blocked Merge it and you die S-Small Size: Small. Simple pull requests that contain little code and should be easy to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants