Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dead iso cat #2359
Dead iso cat #2359
Changes from 19 commits
0624736
6f16789
ceb9509
cee6a16
3c0a143
e140a74
2c58823
2d1719c
127fd1c
ffeb733
011efa6
1458133
4c5a910
1cb6cf5
c41b163
c32c3dc
82d375d
2d865b5
ca59bc9
43fcc60
c71d79f
5854cd7
9bcf4dd
e074d29
a8bab27
dad0474
1e9f211
5d38ae2
339a74d
0da6803
45b1f63
1402738
9cf826d
d067aba
f8e95f1
0920fc0
3b05c99
0f069db
b07b342
9aadcae
2ef288d
bfbab9b
13bff5c
baa79cc
f9daa55
3092b35
00d3684
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible delegation to
<fLib>
,<fvLib>
,<fdecl>
, or<fsDecl>
is listed here, but only to<fvLib>
or<taxonomy>
, below (~10 lines down).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that makes sense: first, there is a general statement on what can get aligned to reduce redundancy of individual feature representations. Then, a specific statement about the specific example mentions
fvLib
that is illustrated, andtaxonomy
that is not illustrated (but I felt it shouldn't not be mentioned).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d recommend using an element instead of the straight quotes. Maybe
<soCalled>common noun</soCalled>
(or<q>
). Same comment goes for line 277 above, and 1625 below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree completely, and the same goes for lines 2664 & 2665 in DI chapter (previous file), too. I do not think
<soCalled>
is appropriate, though.n (But will be happy to change my mind if someone argues convincingly that the part of speech being discussed is not a common noun, rather said encoding is in error; or some such.) My instinct is either<q>
or<term>
?In any case, though, the comma afterwards is missing (before “can” which perhaps should be “may”), and the sentence itself feels a bit run-onny:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sigh, true, I wonder how many straight quotes I have left there... that may take a while ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to use
<q>
for quoted bits, and<soCalled>
for, e.g., names of concepts. Wow, semantic markup... cool. :-)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it's just struck me that maybe (just maybe) some of those could be
<term>
s, but I think that sorting that out needs a bit of quiet and focus, and some target framework, such as that sketched in #2358 -- where you'd, for example, get a pop-up over a<term>
, citing its definition.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I have eliminated simple quotes in the spec and in the FS chapter, with
<q>
where the quotes were straightforward. I even ended up removing quotes where they were not really needed, it seems.There are two sentences in FS that feel "run-onny" (if I interpret that correctly) -- in both cases they talk about some functionality that should/may accompany a suggestion exemplified in an earlier section. The potentially unstable word in both is "concludes", because one could imagine the target section to grow, one day. But today, they are true, and I think that when the FS chapter receives a solid revision, these two instances will be modified if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and I've touched the DI chapter as well.