-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dead iso cat #2359
Dead iso cat #2359
Conversation
… need for redundancy)
…ategories exists at present that could be referenced)
This is now up for re-review, if that's the procedure, but I'm afraid it is going to bug out due to the namespace issue. And I'm also not at all sure how to handle the JSON file that is apparently conflicting. |
Co-authored-by: Helena Bermúdez Sabel <[email protected]>
Co-authored-by: Helena Bermúdez Sabel <[email protected]>
Hey, I'm learning to do this online, and that preserves the attribution to the reviewer -- thanks a lot, I've just gained something. |
P5/Source/Specs/att.datcat.xml
Outdated
target="https://en.wikipedia.org/wiki/Name%E2%80%93value_pair">name-value pair</ref> <q><hi | ||
style="font-family:monospace"><part of speech, common noun></hi></q>, where the name (key) <q>part |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this styling intended here? do you want <code>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an itch, I admit. I initially used <code>
and was a bit horrified by the result -- bold type is not a good device there. So I went around that. Is there a way to use code in such a way that it doesn't get bolded? I tried to locate the processing of the attributes of <code>
in the Stylesheets, but either gave up or something distracted me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it is code. Can we try <code style="font-weight: normal; font-family: monospace;">
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely :-) Thanks.
P5/Source/Specs/att.datcat.xml
Outdated
dictionary or at the level of ODD, in the element <gi>equiv</gi> (child of <gi>elementSpec</gi>), which constitutes an | ||
equivalent of the <ident>att.datcat</ident> class.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On first read, I stumbled here, and I wonder, whether the subordinate clause "in the element …" is helpful or confusing. I think I tend to the latter and would simply drop it, but I'm happy to be overruled!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, will give it a closer look after I get a covid shot in half an hour. The results may be unexpected... ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I think I should rephrase this, the more so that the header is only one such place; fsdDecl is another. And 'constitutes' is maybe too lofty, not sure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, Peter -- you made me realise that I forgot about something. Must have been in a hurry to get to features, and then forgot about this part of the system. And, as it is, the system is not complete in the Guidelines, and one way to go about it would be to delete this part of remarks altogether -- simply not mention the lack of efficiency, and attack the issue after the release, with a slow process.
Another possibility would be to try to amend what I forgot by adding tagUsage
to att.datcat, and this way to save at least part of the picture, while begging questions about another part, but... questions aren't bad, are they. And I'm thinking in parallel with writing this reply, and my current thinking is to try to add tagUsage
, and if the reviewers don't approve, to offer dropping this <p>
element altogether as an alternative.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have addressed this as above, in commit 3b05c99. And in doing so, I realised that I can rearrange some of the secondary egXML
s to be inside the p
children of exemplum
-- it had been a pain to me for a while that (I thought) I could only use one egXML
per exemplum
. But no. So I'd like to push one more commit, merely rearranging the elements of examples slightly, for better readability.
Co-authored-by: Peter Stadler <[email protected]>
Co-authored-by: Peter Stadler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"rather than get repeated" is barbarous. Try "rather than being repeated".
</egXML></p> | ||
<p>Since the above representation takes up a lot of space and quickly becomes redundant and | ||
error-prone, it is possible to delegate the task of aligning with external repositories to | ||
elements such as <gi>fLib</gi>, <gi>fvLib</gi>, <gi>fDecl</gi>, or <gi>fsDecl</gi> to reduce the feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible delegation to <fLib>
, <fvLib>
, <fdecl>
, or <fsDecl>
is listed here, but only to <fvLib>
or <taxonomy>
, below (~10 lines down).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But that makes sense: first, there is a general statement on what can get aligned to reduce redundancy of individual feature representations. Then, a specific statement about the specific example mentions fvLib
that is illustrated, and taxonomy
that is not illustrated (but I felt it shouldn't not be mentioned).
Co-authored-by: Peter Stadler <[email protected]>
after pulling in "Dead iso cat" TEIC/TEI#2359
opened pull request during TEI Council meeting so we can review before October release.