Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/django 4 webhook fix #909

Merged
merged 2 commits into from
Nov 21, 2023
Merged

bug/django 4 webhook fix #909

merged 2 commits into from
Nov 21, 2023

Conversation

shayanaijaz
Copy link
Contributor

Overview

Quick fix for webhooks not working after Django 4 upgrade

Changes

  • Added websocket mapping to asgi.py and removed the mapping previously defined in routing.py

Testing

  1. Submit a job and ensure notifications are working fine

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #909 (827a223) into main (4fc21b6) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
+ Coverage   63.46%   63.47%   +0.01%     
==========================================
  Files         432      431       -1     
  Lines       12406    12404       -2     
  Branches     2585     2585              
==========================================
  Hits         7873     7873              
+ Misses       4317     4315       -2     
  Partials      216      216              
Flag Coverage Δ
javascript 69.75% <ø> (ø)
unittests 57.07% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
server/portal/asgi.py 0.00% <0.00%> (ø)

Copy link
Collaborator

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validated this in dev.cep. Thanks for the quick fix.
Deployment is available in dev.cep.

Copy link
Member

@rstijerina rstijerina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in dev

@chandra-tacc chandra-tacc merged commit 935b143 into main Nov 21, 2023
5 of 6 checks passed
@chandra-tacc chandra-tacc deleted the bug/django-4-webhook-fix branch November 21, 2023 23:16
rstijerina added a commit that referenced this pull request Nov 30, 2023
chandra-tacc pushed a commit that referenced this pull request Dec 1, 2023
* fix ASGI_APPLICATION setting after #909

* update unit test setting
chandra-tacc pushed a commit that referenced this pull request Dec 5, 2023
* fix ASGI_APPLICATION setting after #909

* update unit test setting
chandra-tacc pushed a commit that referenced this pull request Dec 8, 2023
* testing webhook fix

* cleanup
chandra-tacc pushed a commit that referenced this pull request Dec 8, 2023
* fix ASGI_APPLICATION setting after #909

* update unit test setting
chandra-tacc pushed a commit that referenced this pull request Dec 8, 2023
* testing webhook fix

* cleanup
chandra-tacc pushed a commit that referenced this pull request Dec 8, 2023
* fix ASGI_APPLICATION setting after #909

* update unit test setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants