-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick: fix websockets via ASGI_APPLICATION setting after #909 #913
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #913 +/- ##
=======================================
Coverage 63.49% 63.49%
=======================================
Files 431 431
Lines 12412 12412
Branches 2588 2588
=======================================
Hits 7881 7881
Misses 4315 4315
Partials 216 216
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for finding and fixing this.
Not sure what the impact of this unit test setting is, this needs change also.
Thanks, updated that as well for good measure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Validated in https://dev.cep.tacc.utexas.edu/workbench/onboarding/admin with same test steps and I see the events. |
Overview
The setting
ASGI_APPLICATION
needed updating after PR #909.Testing
portal_websockets
container does not error out