Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick: fix websockets via ASGI_APPLICATION setting after #909 #913

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

rstijerina
Copy link
Member

Overview

The setting ASGI_APPLICATION needed updating after PR #909.

Testing

  1. Bring up the portal locally and confirm the portal_websockets container does not error out
  2. Go to https://cep.test/workbench/onboarding/admin and reset your system access step. Confirm you see updates delivered via websocket

Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Merging #913 (5164f14) into main (69aaf0e) will not change coverage.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #913   +/-   ##
=======================================
  Coverage   63.49%   63.49%           
=======================================
  Files         431      431           
  Lines       12412    12412           
  Branches     2588     2588           
=======================================
  Hits         7881     7881           
  Misses       4315     4315           
  Partials      216      216           
Flag Coverage Δ
javascript 69.79% <ø> (ø)
unittests 57.07% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
server/portal/settings/unit_test_settings.py 99.04% <100.00%> (ø)
server/portal/settings/settings.py 0.00% <0.00%> (ø)

Copy link
Collaborator

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for finding and fixing this.

Tested:
Screenshot 2023-11-30 at 7 46 36 PM

Not sure what the impact of this unit test setting is, this needs change also.

@rstijerina
Copy link
Member Author

Not sure what the impact of this unit test setting is, this needs change also.

Thanks, updated that as well for good measure.

Copy link
Contributor

@shayanaijaz shayanaijaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandra-tacc chandra-tacc merged commit 34f7edf into main Dec 1, 2023
5 of 6 checks passed
@chandra-tacc chandra-tacc deleted the bug/asgi-application-setting branch December 1, 2023 20:19
@chandra-tacc
Copy link
Collaborator

Validated in https://dev.cep.tacc.utexas.edu/workbench/onboarding/admin with same test steps and I see the events.

chandra-tacc pushed a commit that referenced this pull request Dec 5, 2023
* fix ASGI_APPLICATION setting after #909

* update unit test setting
chandra-tacc pushed a commit that referenced this pull request Dec 8, 2023
* fix ASGI_APPLICATION setting after #909

* update unit test setting
chandra-tacc pushed a commit that referenced this pull request Dec 8, 2023
* fix ASGI_APPLICATION setting after #909

* update unit test setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants