Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Add logs for slow interfaces #33908

Merged
merged 3 commits into from
Oct 31, 2023
Merged

[Enhancement] Add logs for slow interfaces #33908

merged 3 commits into from
Oct 31, 2023

Conversation

Astralidea
Copy link
Contributor

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@Astralidea Astralidea enabled auto-merge (squash) October 30, 2023 09:46
@Astralidea
Opt.
b40f779 
Signed-off-by: Astralidea <[email protected]>
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@github-actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 7 / 7 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/common/Config.java 1 1 100.00% []
🔵 com/starrocks/http/rest/RestBaseAction.java 6 6 100.00% []

@Astralidea Astralidea merged commit 6488726 into StarRocks:main Oct 31, 2023
36 of 37 checks passed
@github-actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Oct 31, 2023
@github-actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label Oct 31, 2023
@github-actions
Copy link

@Mergifyio backport branch-3.0

@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2023 •
edited
Loading

backport branch-3.2

✅ Backports have been created

@github-actions github-actions bot removed the 3.0 label Oct 31, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2023 •
edited
Loading

backport branch-3.1

✅ Backports have been created

@github-actions
Copy link

@Mergifyio backport branch-2.5

@github-actions github-actions bot removed the 2.5 label Oct 31, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2023 •
edited
Loading

backport branch-3.0

✅ Backports have been created

@mergify
Copy link
Contributor

mergify bot commented Oct 31, 2023 •
edited
Loading

backport branch-2.5

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 31, 2023
@Astralidea @mergify
[Enhancement] Add logs for slow interfaces (#33908)
0e3d975 
Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit 6488726)
mergify bot pushed a commit that referenced this pull request Oct 31, 2023
@Astralidea @mergify
[Enhancement] Add logs for slow interfaces (#33908)
8acbdde 
Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit 6488726)
This was referenced Oct 31, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Oct 31, 2023
@Astralidea @mergify
[Enhancement] Add logs for slow interfaces (#33908)
0f48e15 
Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit 6488726)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/http/ShowDataActionTest.java
@mergify mergify bot mentioned this pull request Oct 31, 2023
Closed
mergify bot pushed a commit that referenced this pull request Oct 31, 2023
@Astralidea @mergify
[Enhancement] Add logs for slow interfaces (#33908)
651e174 
Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit 6488726)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/http/rest/RestBaseAction.java
#	fe/fe-core/src/test/java/com/starrocks/http/ShowDataActionTest.java
@mergify mergify bot mentioned this pull request Oct 31, 2023
Closed
wanpengfei-git pushed a commit that referenced this pull request Oct 31, 2023
@Astralidea @wanpengfei-git
[Enhancement] Add logs for slow interfaces (#33908)
5b536f8 
Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit 6488726)
wanpengfei-git pushed a commit that referenced this pull request Oct 31, 2023
@Astralidea @wanpengfei-git
[Enhancement] Add logs for slow interfaces (#33908)
406e28b 
Signed-off-by: Astralidea <[email protected]>
(cherry picked from commit 6488726)
This was referenced Oct 31, 2023
Merged
Merged
Moonm3n pushed a commit to Moonm3n/starrocks that referenced this pull request Oct 31, 2023
@Astralidea @Moonm3n
[Enhancement] Add logs for slow interfaces (StarRocks#33908)
a1aad7e 
Signed-off-by: Astralidea <[email protected]>
Signed-off-by: Moonm3n <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-shelby stephen-shelby stephen-shelby approved these changes

@imay imay imay approved these changes

Assignees

@Astralidea Astralidea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Astralidea @imay @stephen-shelby