Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade savon httpi to fix integration dependency errors #18

Merged
merged 92 commits into from
Jun 26, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
92 commits
Select commit Hold shift + click to select a range
9b92e6e
allow specification of a different WSDL
May 30, 2012
8ae72a9
Support using sandbox endpoint via configuration
Jun 7, 2012
bd97d1e
Run integration tests against sandbox accounts
Jun 7, 2012
a9a6e32
support multiple product rate plans in subscribe requests
jmoline Jun 18, 2012
f2392a7
adding method for backward compatibility of single product_rate_plan …
jmoline Jun 18, 2012
d20546a
payment_method should allow for credit cards expiring this year
jmoline Jun 20, 2012
8c14557
adding specs to verify validation
jmoline Jun 25, 2012
c47d919
adding attribute assignment method to base, with specs
jmoline Jun 25, 2012
fc6328a
Merge branch 'payment_method_year' of https://github.com/jmoline/zuor…
oesmith Jun 27, 2012
c47babe
Prefer '>= year' over '> last year'.
oesmith Jun 27, 2012
4e66f55
product_rate_plan= method shouldn't be protected
jmoline Jul 2, 2012
b8b2d1f
DRYing object xml generation methods
jmoline Jul 2, 2012
b08ebaf
specs to cover modifications to validation methods and turning produc…
jmoline Jul 2, 2012
6b06963
Use our @google emails
kalbasit Nov 21, 2012
40ca7e2
Update dependencies - inspired by and heavily lifted from @mdemin914
Nov 26, 2013
1122cc4
As it turns out, some months have 31 days.
nirvdrum Oct 31, 2012
df90fd2
Set the account_id value after successfull subscribing.
nirvdrum Sep 14, 2012
d02820d
account_id isn't always required. It may be blank for :subscribe calls.
nirvdrum Sep 4, 2012
eb66903
Allow passing just the product_rate_plan_id rather than a fully mater…
nirvdrum Sep 4, 2012
fd51194
Updated @nirvdrum spec to support new return values
Nov 26, 2013
d4e9af6
Revert "Updated @nirvdrum spec to support new return values"
Nov 26, 2013
63f9ef8
Revert "Allow passing just the product_rate_plan_id rather than a ful…
Nov 26, 2013
0f59b53
Merge remote-tracking branch 'jmoline/multiple_rate_plans' into 1.0
Nov 26, 2013
8142d68
Update license and added CONTRIBUTING
Bram-- Nov 28, 2013
27e26c1
Re-add F
Bram-- Dec 5, 2013
a46b0dc
support multiple product rate plans in subscribe requests
jmoline Jun 18, 2012
6ef6b00
adding method for backward compatibility of single product_rate_plan …
jmoline Jun 18, 2012
6f37596
product_rate_plan= method shouldn't be protected
jmoline Jul 2, 2012
b7faf09
DRYing object xml generation methods
jmoline Jul 2, 2012
5ec27e5
specs to cover modifications to validation methods and turning produc…
jmoline Jul 2, 2012
c3eca59
Update dependencies - inspired by and heavily lifted from @mdemin914
Nov 26, 2013
b353b0f
As it turns out, some months have 31 days.
nirvdrum Oct 31, 2012
ee7b42a
Set the account_id value after successfull subscribing.
nirvdrum Sep 14, 2012
2d0bdee
account_id isn't always required. It may be blank for :subscribe calls.
nirvdrum Sep 4, 2012
fb51b3b
Allow passing just the product_rate_plan_id rather than a fully mater…
nirvdrum Sep 4, 2012
8fc1d4c
Updated @nirvdrum spec to support new return values
Nov 26, 2013
8b97f32
Revert "Updated @nirvdrum spec to support new return values"
Nov 26, 2013
8d3eb3e
Revert "Allow passing just the product_rate_plan_id rather than a ful…
Nov 26, 2013
b969579
Merge commit '0f59b53' into v1.0
Bram-- Dec 10, 2013
5886a88
Implemented the :amend call.
nirvdrum Sep 9, 2012
6ed98a5
Add jmonline to contributor list and fix a typo
Nov 26, 2013
789ccd2
Fix up integration specs
Bram-- Nov 28, 2013
8666679
Merge pull request #15 from wildfireapp/v1.0
Bram-- Dec 10, 2013
f5156e0
It's `log: true` not `logger: true`
chadoh Aug 21, 2014
33a3a71
fixing make_client to use savon 2.0 config
mdemin914 Oct 16, 2014
5ba1025
Update README.md
mdemin914 Nov 11, 2014
4141323
Update README.md
mdemin914 Feb 25, 2015
37291ca
Update README.md
mdemin914 Feb 25, 2015
1202129
fixed base.query function
mdemin914 Apr 1, 2015
45ed72a
Merge branch 'master' of https://github.com/zuorasc/zuora
mdemin914 Apr 1, 2015
08296bb
fixing subscribe request
mdemin914 Apr 2, 2015
89a87b1
enable services url
mdemin914 Apr 27, 2015
bad21dd
Update zuora.gemspec
mdemin914 Jun 1, 2015
9799fb4
Update payment.rb
dmhalejr Jun 2, 2015
bf09f13
Adds testing for ruby 2.x
Dec 1, 2015
a7051d8
Merge pull request #21 from dmhalejr/patch-1
mdemin914 Apr 18, 2016
74236d0
Merge pull request #29 from jwg2s/feature/travis-ruby2
mdemin914 Apr 18, 2016
fb31629
Merge pull request #18 from chadoh/patch-1
mdemin914 Apr 18, 2016
c2fe7ae
works with ruby 2.3.1, update to wsdl 78, update spec, remove date/da…
mdemin914 Aug 16, 2016
f46dfc8
don't query activeCurrencies for product rate plans with other fields
mdemin914 Sep 27, 2016
4574572
Merge remote-tracking branch 'upstream/master' into upgrade-savon-httpi
banjoko01 Jun 14, 2024
ee1e873
- Fix failing specs
banjoko01 Jun 14, 2024
ae4a946
- Update httpi to `~> 3` and related dependencies
banjoko01 Jun 14, 2024
462f494
- Update httpi to `< 4.0` to resolve `uninitialized constant Rack::Ut…
banjoko01 Jun 14, 2024
904f3fe
Downgrade httpi to 3.0
tapan-sh Jun 17, 2024
f756577
Downgrade savon to 2.14
tapan-sh Jun 17, 2024
382f6ec
Loosen httpi and savon gem
tapan-sh Jun 17, 2024
17e4cca
Bump Ruby version to 3.2
tapan-sh Jun 17, 2024
7beffa6
Bump Ruby version
tapan-sh Jun 17, 2024
28c8f19
Resolve gem dependency errors
tapan-sh Jun 18, 2024
067d069
Use Ruby 3.2.0
tapan-sh Jun 18, 2024
34721e2
Resolve undefined method `exists?' for File:Class
tapan-sh Jun 18, 2024
4dd4867
Use Ruby 3.2.0
tapan-sh Jun 18, 2024
f96fb18
Add i18n dependency
tapan-sh Jun 18, 2024
fe953de
- Add Ruby matrix to CI
banjoko01 Jun 19, 2024
9bf0617
- Loosen up httpi gem
banjoko01 Jun 19, 2024
a43ab7e
- Loosen up sqlite3 gem
banjoko01 Jun 19, 2024
81f6423
Add appraisals gem - Support Rails 4 - 7
tapan-sh Jun 19, 2024
df11da1
Merge pull request #19 from Sage/add-appraisal
tapan-sh Jun 21, 2024
841f53b
- Revert commented out validations
banjoko01 Jun 21, 2024
4890217
- Revert `WSDL` definition to the current pattern
banjoko01 Jun 21, 2024
6f059cf
- Revert `WSDL` definition to the latest pattern
banjoko01 Jun 21, 2024
46b7ecf
- Insert commented lines on how `wsdl` was previously defined till we…
banjoko01 Jun 21, 2024
2016532
- Remove `CONTRIBUTING.md` file
banjoko01 Jun 25, 2024
48578b7
- Revert use of `config.wsdl_path` pattern
banjoko01 Jun 25, 2024
04f281f
- Revert overriden validations from upstream
banjoko01 Jun 25, 2024
22c3381
- Add instructions on how to run specs with appraisal to `README`
banjoko01 Jun 26, 2024
40ff652
- Restore `WSDL` constant definition and test coverage
banjoko01 Jun 26, 2024
0d39260
- Comment out `refund_Date` validation to align with upstream changes
banjoko01 Jun 26, 2024
1afc8b1
- Address changes to `README` file
banjoko01 Jun 26, 2024
cd9b4ee
- Prefix gem name with `sage-`
banjoko01 Jun 26, 2024
5a06bc4
- Remove redundants debugging gems
banjoko01 Jun 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib/zuora/api.rb
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,11 @@ def client
# @return [Hash]
attr_accessor :options

WSDL = File.expand_path('../../../wsdl/zuora.a.78.0.wsdl', __FILE__)
WSDL = if config&.wsdl_path
config.wsdl_path
else
File.expand_path('../../../wsdl/zuora.a.78.0.wsdl', __FILE__)
end
SOAP_VERSION = 2
SANDBOX_ENDPOINT = 'https://apisandbox.zuora.com/apps/services/a/78.0'

Expand Down
1 change: 0 additions & 1 deletion lib/zuora/objects.rb
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,5 @@ module Objects
autoload :RatePlanData, 'zuora/objects/rate_plan_data'
autoload :RatePlanChargeData, 'zuora/objects/rate_plan_charge_data'
# autoload :Refund, 'zuora/objects/refund'
# autoload :RefundInvoicePayment, 'zuora/objects/refund_invoice_payment'
end
end
12 changes: 6 additions & 6 deletions lib/zuora/objects/amendment.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,20 @@ class Amendment < Base
validates_length_of :name, :maximum => 100
validates_inclusion_of :auto_renew, :in => [true, false], :allow_nil => true
validates_length_of :code, :maximum => 50, :allow_nil => true
# validates_datetime_of :contract_effective_date, :allow_nil => true
# validates_datetime_of :customer_acceptance_date, :allow_nil => true
# validates_datetime_of :effective_date, :allow_nil => true
# validates_datetime_of :service_activation_date, :if => Proc.new { |a| a.status == 'PendingAcceptance' }
validates_datetime_of :contract_effective_date, :allow_nil => true
validates_datetime_of :customer_acceptance_date, :allow_nil => true
validates_datetime_of :effective_date, :allow_nil => true
validates_datetime_of :service_activation_date, :if => Proc.new { |a| a.status == 'PendingAcceptance' }
banjoko01 marked this conversation as resolved.
Show resolved Hide resolved
validates_length_of :description, :maximum => 500, :allow_nil => true
validates_numericality_of :initial_term, :if => Proc.new { |a| a.type == 'TermsAndConditions' }
validates_numericality_of :renewal_term, :if => Proc.new { |a| a.type == 'TermsAndConditions' }
# validates_date_of :term_start_date, :if => Proc.new { |a| a.type == 'TermsAndConditions' }
validates_date_of :term_start_date, :if => Proc.new { |a| a.type == 'TermsAndConditions' }
validates_presence_of :destination_account_id, :if => Proc.new {|a| a.type == 'OwnerTransfer' }
validates_presence_of :destination_invoice_owner_id, :if => Proc.new {|a| a.type == 'OwnerTransfer' }
validates_inclusion_of :status, :in => ["Completed", "Cancelled", "Draft", "Pending Acceptance", "Pending Activation"]
validates_inclusion_of :term_type, :in => ['TERMED', 'EVERGREEN'], :allow_nil => true
validates_inclusion_of :type, :in => ['Cancellation', 'NewProduct', 'OwnerTransfer', 'RemoveProduct', 'Renewal', 'UpdateProduct', 'TermsAndConditions']
validates_presence_of :rate_plan_data, :if => Proc.new { |a| ['NewProduct', 'RemoveProduct', 'UpdateProduct'].include?(a.type) }
validates_presence_of :rate_plan_data, :if => Proc.new { |a| ['NewProduct', 'RemoveProduct', 'UpdateProduct'].include?(a.type) }, :only => :apply_percentage_discount

attr_accessor :amendment_ids
attr_accessor :invoice_id
Expand Down
4 changes: 2 additions & 2 deletions lib/zuora/objects/invoice.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ class Invoice < Base
validates_numericality_of :amount
validates_numericality_of :balance, :allow_nil => true
validates_length_of :comments, :maximum => 255
# validates_datetime_of :due_date
# validates_datetime_of :invoice_date
validates_datetime_of :due_date
validates_datetime_of :invoice_date
validates_inclusion_of :includes_one_time, :in => [true, false]
validates_inclusion_of :includes_recurring, :in => [true, false]
validates_inclusion_of :includes_usage, :in => [true, false]
Expand Down
Loading