Upgrade savon httpi to fix integration dependency errors #18

banjoko01 · 2024-06-14T12:34:34Z

This PR:

Update the original repo here with the forked repo, whilst keeping all custom changes made.
Updates savon, httpi and wasabi gem version

Support proper config object for authentication

…in subreq

…into jmoline-payment_method_year

…t_rate_plan into product_rate_plans

…ialized object when creating a SubscribeRequest.

This reverts commit fd51194.

…ly materialized object when creating a SubscribeRequest." This reverts commit eb66903.

Support multiple rate plans in a subscription request. Conflicts: lib/zuora/objects/subscribe_request.rb

…in subreq

…t_rate_plan into product_rate_plans

lib/zuora/objects/amendment.rb

ianoxley

There's a lot of commented out code that either was commented out and now isn't, or wasn't commented out and now is. Have all these changes come from upstream?

lib/zuora/objects/credit_balance_adjustment.rb

lib/zuora/objects/invoice.rb

lib/zuora/objects/invoice_adjustment.rb

lib/zuora/objects/invoice_item.rb

lib/zuora/objects/invoice_item_adjustment.rb

lib/zuora/objects/subscription.rb

lib/zuora/objects/usage.rb

lib/zuora/api.rb

CONTRIBUTING.md

README.md

- Update repo to clone from in `README.md`

- Update test accordingly

- Update validations for attributes with changed datatype. `(i.e Datetime to date)`

lib/zuora/api.rb

ianoxley

If we can add those how to run specs with appraisal instructions to the README too that'd be great.

lib/zuora/api.rb

lib/zuora/objects/refund.rb

lib/zuora/objects/payment_method.rb

- Refactor `fetch_wsdl`

ianoxley

Just some minor comments on the README changes

README.md

zuora.gemspec

Jacob Burkhart & Andy Delcambre and others added 30 commits June 7, 2012 12:54

allow specification of a different WSDL

9b92e6e

Support using sandbox endpoint via configuration

8ae72a9

Run integration tests against sandbox accounts

bd97d1e

Support proper config object for authentication

support multiple product rate plans in subscribe requests

a9a6e32

adding method for backward compatibility of single product_rate_plan …

f2392a7

…in subreq

payment_method should allow for credit cards expiring this year

d20546a

adding specs to verify validation

8c14557

adding attribute assignment method to base, with specs

c47d919

Merge branch 'payment_method_year' of https://github.com/jmoline/zuora …

fc6328a

…into jmoline-payment_method_year

Prefer '>= year' over '> last year'.

c47babe

product_rate_plan= method shouldn't be protected

4e66f55

DRYing object xml generation methods

b8b2d1f

specs to cover modifications to validation methods and turning produc…

b08ebaf

…t_rate_plan into product_rate_plans

Use our @google emails

6b06963

Update dependencies - inspired by and heavily lifted from @mdemin914

40ca7e2

As it turns out, some months have 31 days.

1122cc4

Set the account_id value after successfull subscribing.

df90fd2

account_id isn't always required. It may be blank for :subscribe calls.

d02820d

Allow passing just the product_rate_plan_id rather than a fully mater…

eb66903

…ialized object when creating a SubscribeRequest.

Updated @nirvdrum spec to support new return values

fd51194

Revert "Updated @nirvdrum spec to support new return values"

d4e9af6

This reverts commit fd51194.

Revert "Allow passing just the product_rate_plan_id rather than a ful…

63f9ef8

…ly materialized object when creating a SubscribeRequest." This reverts commit eb66903.

Merge remote-tracking branch 'jmoline/multiple_rate_plans' into 1.0

0f59b53

Support multiple rate plans in a subscription request. Conflicts: lib/zuora/objects/subscribe_request.rb

Update license and added CONTRIBUTING

8142d68

Re-add F

27e26c1

support multiple product rate plans in subscribe requests

a46b0dc

adding method for backward compatibility of single product_rate_plan …

6ef6b00

…in subreq

product_rate_plan= method shouldn't be protected

6f37596

DRYing object xml generation methods

b7faf09

specs to cover modifications to validation methods and turning produc…

5ec27e5

…t_rate_plan into product_rate_plans

banjoko01 marked this pull request as ready for review June 21, 2024 11:08

banjoko01 requested review from ianoxley, tapan-sh, noodl and adamgeorgeson June 21, 2024 11:09

tapan-sh reviewed Jun 21, 2024

View reviewed changes

lib/zuora/objects/amendment.rb Outdated Show resolved Hide resolved

ianoxley reviewed Jun 21, 2024

View reviewed changes

banjoko01 added 3 commits June 25, 2024 12:15

- Remove CONTRIBUTING.md file

2016532

- Update repo to clone from in `README.md`

- Revert use of config.wsdl_path pattern

48578b7

- Update test accordingly

- Revert overriden validations from upstream

04f281f

- Update validations for attributes with changed datatype. `(i.e Datetime to date)`

banjoko01 requested review from ianoxley and tapan-sh June 25, 2024 12:19

ianoxley reviewed Jun 25, 2024

View reviewed changes

lib/zuora/api.rb Outdated Show resolved Hide resolved

ianoxley reviewed Jun 25, 2024

View reviewed changes

lib/zuora/api.rb Outdated Show resolved Hide resolved

lib/zuora/api.rb Outdated Show resolved Hide resolved

lib/zuora/objects/refund.rb Outdated Show resolved Hide resolved

lib/zuora/objects/payment_method.rb Show resolved Hide resolved

banjoko01 added 3 commits June 26, 2024 11:09

- Add instructions on how to run specs with appraisal to README

22c3381

- Restore WSDL constant definition and test coverage

40ff652

- Refactor `fetch_wsdl`

- Comment out refund_Date validation to align with upstream changes

0d39260

banjoko01 requested a review from ianoxley June 26, 2024 11:01

ianoxley previously approved these changes Jun 26, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

- Address changes to README file

1afc8b1

banjoko01 dismissed ianoxley’s stale review via 1afc8b1 June 26, 2024 12:43

ianoxley previously approved these changes Jun 26, 2024

View reviewed changes

- Prefix gem name with sage-

cd9b4ee

banjoko01 dismissed ianoxley’s stale review via cd9b4ee June 26, 2024 13:15

ianoxley previously approved these changes Jun 26, 2024

View reviewed changes

zuora.gemspec Outdated Show resolved Hide resolved

- Remove redundants debugging gems

5a06bc4

banjoko01 dismissed ianoxley’s stale review via 5a06bc4 June 26, 2024 13:32

ianoxley approved these changes Jun 26, 2024

View reviewed changes

banjoko01 merged commit 25ab50c into master Jun 26, 2024
6 checks passed

adamgeorgeson deleted the upgrade-savon-httpi branch July 1, 2024 09:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade savon httpi to fix integration dependency errors #18

Upgrade savon httpi to fix integration dependency errors #18

banjoko01 commented Jun 14, 2024

ianoxley left a comment

ianoxley left a comment

ianoxley left a comment

Upgrade savon httpi to fix integration dependency errors #18

Upgrade savon httpi to fix integration dependency errors #18

Conversation

banjoko01 commented Jun 14, 2024

ianoxley left a comment

Choose a reason for hiding this comment

ianoxley left a comment

Choose a reason for hiding this comment

ianoxley left a comment

Choose a reason for hiding this comment