Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Onboarding Flow]- Write test after the "Generate Chaincode" button is clicked #721

Merged
merged 5 commits into from
Nov 2, 2023
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions app/components/identity-steps/step-four.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
A private key that you need to use in your profile service URL and deploy
for source that you're the source of the URL
</p>
{{#if this.isChaincodeClicked}}
{{#if @isChaincodeClicked}}
<div data-test='chaincode-container' class='chaincode-container'>
<div
data-test='chaincode-container__value'
Expand All @@ -19,7 +19,7 @@
{{#if this.hideChaincode}}
********************
{{else}}
{{this.Chaincode}}
{{@chaincode}}
{{/if}}
</div>
<div
Expand Down Expand Up @@ -49,11 +49,11 @@
</div>
{{else}}
<Reusables::Button
@text={{this.Chaincode}}
@text={{@chaincode}}
@variant='chaincode'
@onClick={{this.handleGenerateChaincode}}
@onClick={{@handleGenerateChaincode}}
@test='chaincode'
@isLoading={{this.isLoading}}
@isLoading={{@isLoading}}
@type='button'
/>
{{/if}}
Expand Down
46 changes: 0 additions & 46 deletions app/components/identity-steps/step-four.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,58 +3,12 @@ import { tracked } from '@glimmer/tracking';
import { action } from '@ember/object';
import { inject as service } from '@ember/service';
import { toastNotificationTimeoutOptions } from '../../constants/toast-notification';
import { APPS } from '../../constants/urls';

export default class IdentityStepsStepFourComponent extends Component {
@service toast;
@tracked Chaincode = 'Generate Chaincode';
@tracked isChaincodeClicked = false;
@tracked hideChaincode = true;
@tracked isCopyClicked = false;
@tracked isChaincodePageButtonDisabled = true;
@tracked isLoading = false;

@action async handleGenerateChaincode(e) {
e.preventDefault();

this.isLoading = true;

try {
const response = await fetch(`${APPS.API_BACKEND}/users/chaincode`, {
method: 'GET',
headers: {
'Content-Type': 'application/json',
},
credentials: 'include',
});

const { chaincode } = await response.json();

if (response.ok) {
this.Chaincode = chaincode;
this.isChaincodeClicked = true;
this.toast.info(
'Generated New Chaincode!!',
'',
toastNotificationTimeoutOptions
);
} else {
this.toast.error(
'Something went wrong. Please check console errors.',
'',
toastNotificationTimeoutOptions
);
}
} catch (error) {
this.toast.error(
'Something went wrong. Please check console errors.',
'',
toastNotificationTimeoutOptions
);
} finally {
this.isLoading = false;
}
}

@action toggleEye() {
this.hideChaincode = !this.hideChaincode;
Expand Down
8 changes: 7 additions & 1 deletion app/components/stepper-signup.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,13 @@
{{else if (eq this.currentStep 9)}}
<IdentitySteps::StepThree @startHandler={{this.startHandler}} />
{{else if (eq this.currentStep 10)}}
<IdentitySteps::StepFour @startHandler={{this.startHandler}} />
<IdentitySteps::StepFour
@startHandler={{this.startHandler}}
@chaincode={{@chaincode}}
@isChaincodeClicked={{@isChaincodeClicked}}
@isLoading={{@isLoading}}
@handleGenerateChaincode={{@handleGenerateChaincode}}
/>
{{else if (eq this.currentStep 11)}}
<IdentitySteps::StepFive @startHandler={{this.startHandler}} />
{{else if (eq this.currentStep 12)}}
Expand Down
49 changes: 49 additions & 0 deletions app/controllers/join.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,63 @@
import Controller from '@ember/controller';
import { inject as service } from '@ember/service';
import { APPS } from '../constants/urls';
import { tracked } from '@glimmer/tracking';
import { action } from '@ember/object';
import { toastNotificationTimeoutOptions } from '../constants/toast-notification';

export default class JoinController extends Controller {
@service router;
@service login;
@service featureFlag;
@tracked Chaincode = 'Generate Chaincode';
satyam73 marked this conversation as resolved.
Show resolved Hide resolved
@tracked isChaincodeClicked = false;
@tracked isLoading = false;

queryParams = ['step', 'dev'];

get isDevMode() {
return this.featureFlag.isDevMode;
}

@action async handleGenerateChaincode(e) {
e.preventDefault();

this.isLoading = true;

try {
const response = await fetch(`${APPS.API_BACKEND}/users/chaincode`, {
method: 'GET',
headers: {
'Content-Type': 'application/json',
},
credentials: 'include',
});

const { chaincode } = await response.json();

if (response.ok) {
this.Chaincode = chaincode;
this.isChaincodeClicked = true;
this.toast.info(
'Generated New Chaincode!!',
'',
toastNotificationTimeoutOptions
);
} else {
this.toast.error(
'Something went wrong. Please check console errors.',
'',
toastNotificationTimeoutOptions
);
}
satyam73 marked this conversation as resolved.
Show resolved Hide resolved
} catch (error) {
this.toast.error(
'Something went wrong. Please check console errors.',
'',
toastNotificationTimeoutOptions
);
} finally {
this.isLoading = false;
}
}
}
7 changes: 6 additions & 1 deletion app/templates/join.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@
</OnboardingCard>
{{else}}
{{#if this.isDevMode}}
<StepperSignup />
<StepperSignup
@chaincode={{this.Chaincode}}
@isChaincodeClicked={{this.isChaincodeClicked}}
@isLoading={{this.isLoading}}
@handleGenerateChaincode={{this.handleGenerateChaincode}}
/>
{{else}}
<Stepper />
{{/if}}
Expand Down
65 changes: 52 additions & 13 deletions tests/integration/components/identity-steps/step-four-test.js
satyam73 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { module, skip, test } from 'qunit';
import { module, test } from 'qunit';
import { setupRenderingTest } from 'website-www/tests/helpers';
import { render, click } from '@ember/test-helpers';
import { hbs } from 'ember-cli-htmlbars';
Expand All @@ -9,8 +9,12 @@ module('Integration | Component | identity-steps/step-four', function (hooks) {
test('render main container div on generate chaincode page', async function (assert) {
assert.expect(2);
this.set('startHandler', () => {});
this.set('handleGenerateChaincode', () => {});
await render(
hbs`<IdentitySteps::StepFour @startHandler={{this.startHandler}} />`
hbs`<IdentitySteps::StepFour
@startHandler={{this.startHandler}}
@handleGenerateChaincode={{this.handleGenerateChaincode}}
/>`
);

assert.dom('[data-test=chaincode]').exists();
Expand All @@ -20,8 +24,12 @@ module('Integration | Component | identity-steps/step-four', function (hooks) {
test('render heading on generate chaincode page', async function (assert) {
assert.expect(2);
this.set('startHandler', () => {});
this.set('handleGenerateChaincode', () => {});
await render(
hbs`<IdentitySteps::StepFour @startHandler={{this.startHandler}} />`
hbs`<IdentitySteps::StepFour
@startHandler={{this.startHandler}}
@handleGenerateChaincode={{this.handleGenerateChaincode}}
/>`
);
assert.dom('[data-test=heading]').hasClass('chaincode-page__heading');
assert.dom('[data-test=heading]').hasText('Chaincode Generation');
Expand All @@ -30,8 +38,12 @@ module('Integration | Component | identity-steps/step-four', function (hooks) {
test('render description on generate chaincode page', async function (assert) {
assert.expect(2);
this.set('startHandler', () => {});
this.set('handleGenerateChaincode', () => {});
await render(
hbs`<IdentitySteps::StepFour @startHandler={{this.startHandler}} />`
hbs`<IdentitySteps::StepFour
@startHandler={{this.startHandler}}
@handleGenerateChaincode={{this.handleGenerateChaincode}}
/>`
);
assert
.dom('[data-test=description]')
Expand All @@ -46,8 +58,16 @@ module('Integration | Component | identity-steps/step-four', function (hooks) {
test('render Generation Chaincode button on chaincode page', async function (assert) {
assert.expect(2);
this.set('startHandler', () => {});
this.set('handleGenerateChaincode', () => {});
this.set('chaincode', 'Generate Chaincode');
this.set('isChaincodeClicked', false);
await render(
hbs`<IdentitySteps::StepFour @startHandler={{this.startHandler}} />`
hbs`<IdentitySteps::StepFour
@startHandler={{this.startHandler}}
@handleGenerateChaincode={{this.handleGenerateChaincode}}
@isChaincodeClicked={{this.isChaincodeClicked}}
@chaincode={{this.chaincode}}
/>`
);
assert.dom('[data-test-button=chaincode]').hasText('Generate Chaincode');
assert.dom('[data-test-button=chaincode]').hasProperty('type', 'button');
Expand All @@ -56,28 +76,40 @@ module('Integration | Component | identity-steps/step-four', function (hooks) {
test('render disabled Next button on chaincode page', async function (assert) {
assert.expect(2);
this.set('startHandler', () => {});
this.set('handleGenerateChaincode', () => {});
await render(
hbs`<IdentitySteps::StepFour @startHandler={{this.startHandler}} />`
hbs`<IdentitySteps::StepFour
@startHandler={{this.startHandler}}
@handleGenerateChaincode={{this.handleGenerateChaincode}}
/>`
);
assert.dom('[data-test-button=next]').hasText('Next');
assert.dom('[data-test-button=next]').hasProperty('disabled', true);
});

skip('Clicking "Generate Chaincode" button renders div with text and 2 button with icons on Chaincode page', async function (assert) {
test('Clicking "Generate Chaincode" button renders div with text and 2 button with icons on Chaincode page', async function (assert) {
assert.expect(6);
this.set('startHandler', () => {});
this.set('handleGenerateChaincode', () => {
this.set('isChaincodeClicked', true);
});

await render(
hbs`<IdentitySteps::StepFour @startHandler={{this.startHandler}} />`
hbs`<IdentitySteps::StepFour
@startHandler={{this.startHandler}}
@handleGenerateChaincode={{this.handleGenerateChaincode}}
@isChaincodeClicked={{this.isChaincodeClicked}}
/>`
);
await click('[data-test-button=chaincode]');

assert.dom('[data-test=chaincode-container]').exists();
assert
.dom('[data-test=chaincode-container__value]')
.hasClass('chaincode-container__value');
.hasClass('chaincode-container__value-invisible');
assert
.dom('[data-test=chaincode-container__value]')
.hasText('**************');
.hasText('********************');

assert
.dom('[data-test=chaincode-container__action]')
Expand All @@ -87,13 +119,20 @@ module('Integration | Component | identity-steps/step-four', function (hooks) {
assert.dom('[data-test-button=copy-icon]').hasClass('chaicode-button-icon');
});

skip('Clicking eye-icon button show generated code', async function (assert) {
test('Clicking eye-icon button show generated code', async function (assert) {
assert.expect(1);
this.set('startHandler', () => {});
this.set('handleGenerateChaincode', () => {});
this.set('isChaincodeClicked', true);
this.set('chaincode', 'hv2hz3xh1h');
await render(
hbs`<IdentitySteps::StepFour @startHandler={{this.startHandler}} />`
hbs`<IdentitySteps::StepFour
@startHandler={{this.startHandler}}
@handleGenerateChaincode={{this.handleGenerateChaincode}}
@isChaincodeClicked={{this.isChaincodeClicked}}
@chaincode={{this.chaincode}}
/>`
);
await click('[data-test-button=chaincode]');
await click('[data-test-button=eye-icon]');

assert.dom('[data-test=chaincode-container__value]').hasText('hv2hz3xh1h');
Expand Down
Loading