Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Onboarding Flow]- Write test after the "Generate Chaincode" button is clicked #721

Merged
merged 5 commits into from
Nov 2, 2023
Merged

[Onboarding Flow]- Write test after the "Generate Chaincode" button is clicked #721

merged 5 commits into from
Nov 2, 2023

Conversation

shubhamsinghbundela
Copy link
Contributor

@shubhamsinghbundela shubhamsinghbundela commented Oct 31, 2023 •
edited
Loading

Issue Closes #714

What is the change?

  • Before fetching an API in an component, but Now I moved it to the controller file
  • Fix all the test and skip test
  • under feature flag

Is Development Tested?

  • Yes
  • No

Test Stats

chrome_W9awOijvkj.mp4

After Change Video

chrome_Y6J2GO89pZ.mp4

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 31, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: d6b3bbd
Status: ✅  Deploy successful!
Preview URL: https://9079cf81.www-rds.pages.dev
Branch Preview URL: https://fix-chaincode-code.www-rds.pages.dev

View logs

@shubhamsinghbundela shubhamsinghbundela self-assigned this Oct 31, 2023
satyam73
satyam73 requested changes Oct 31, 2023
View reviewed changes
app/controllers/join.js Outdated Show resolved Hide resolved
app/controllers/join.js Outdated Show resolved Hide resolved
tests/integration/components/identity-steps/step-four-test.js Outdated Show resolved Hide resolved
satyam73
satyam73 approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@satyam73 satyam73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satyam73 satyam73 merged commit b29f4a0 into develop-ember Nov 2, 2023
2 checks passed
@satyam73 satyam73 deleted the fix/chaincode-code branch November 2, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satyam73 satyam73 satyam73 approved these changes

@gauravsinhaweb gauravsinhaweb gauravsinhaweb approved these changes

Assignees

@shubhamsinghbundela shubhamsinghbundela

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubhamsinghbundela @gauravsinhaweb @satyam73