Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: idle page time formatting #970

Merged
merged 10 commits into from
Oct 28, 2023
Merged

Fix: idle page time formatting #970

merged 10 commits into from
Oct 28, 2023

Conversation

anishpawaskar
Copy link
Contributor

@anishpawaskar anishpawaskar commented Oct 26, 2023 •
edited
Loading

Description:

  • The idle page where we show idle users and their time/day for how long they have been idle. So to show time/day we are not using UTC time format.
  • So i have added UTC time format there.

Anything you would like to inform the reviewer about:

  • Didn't write any test because test are already written for card component.

Dev Tested:

  • Yes

Images/video of the change:

Idle Users _ Status Real Dev Squad _ Status Real Dev Squad - Google Chrome 27-10-2023 03_26_09

@vercel
Copy link

vercel bot commented Oct 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2023 8:38pm

iamitprakash
iamitprakash previously approved these changes Oct 27, 2023
View reviewed changes
yesyash
yesyash requested changes Oct 27, 2023
View reviewed changes
src/helperFunctions/getIdleSinceText.ts Outdated Show resolved Hide resolved
src/helperFunctions/getIdleSinceText.ts Outdated Show resolved Hide resolved
yesyash
yesyash requested changes Oct 27, 2023
View reviewed changes
src/helperFunctions/getIdleSinceText.ts Outdated Show resolved Hide resolved
src/helperFunctions/getIdleSinceText.ts Outdated Show resolved Hide resolved
@yesyash yesyash merged commit d61b07e into develop Oct 28, 2023
2 checks passed
@yesyash yesyash deleted the fix-getIdleSinceText-function branch October 28, 2023 20:44
@anishpawaskar anishpawaskar mentioned this pull request Oct 31, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesyash yesyash yesyash approved these changes

@Achintya-Chatterjee Achintya-Chatterjee Achintya-Chatterjee approved these changes

@shubhamsinghbundela shubhamsinghbundela shubhamsinghbundela left review comments

@iamitprakash iamitprakash iamitprakash left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anishpawaskar @iamitprakash @Achintya-Chatterjee @yesyash @shubhamsinghbundela