Dev to main sync #968
Merged
Dev to main sync #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…tatus tabs (#923) * Removed the task filter copy on status site, (ie) tabs section for larger devices and Select dropdown task filter for smaller devices are removed Signed-off-by: Aneena John Xavier <[email protected]> * Test case fixes: - Fixed failing test cases for seacrch button handler and input search param handling test cases on tasks pages - Removed test cases corresponding to tabs component. - Removed unneccesary import and variables corresponding to Tabs component in TasksContent.tsx - css classes removed for the same in tasks scss module Signed-off-by: Aneena John Xavier <[email protected]> * Removed loggers for debuggers in test cases Signed-off-by: Aneena John Xavier <[email protected]> * Resolved conflicts Signed-off-by: Aneena John Xavier <[email protected]> * Updated search btn handler test case as it was getting called twice on single click on test Signed-off-by: Aneena John Xavier <[email protected]> * Feature flag updates for second status tabs: - The secondary dropdown will be rendered on UI only with feature flag (ie) when dev is passed as true in queryparam `?dev=true` - Updated task container css to compensate for the width reduction when the secondary status tab is removed. - Test cases updated to test the secondary tabs only when dev is true Signed-off-by: Aneena John Xavier <[email protected]> * Removed commented tests Signed-off-by: Aneena John Xavier <[email protected]> * Merged changes from develop branch and updated the feature flag to not render secondary tabs Signed-off-by: Aneena John Xavier <[email protected]> * fix- testing fix for failing testcase on git pipeline for taskdetail title and desc should not with same values case Signed-off-by: Aneena John Xavier <[email protected]> * Replace null with react fragment to handle the false condition Signed-off-by: Aneena John Xavier <[email protected]> * Updated testcases title Signed-off-by: Aneena John Xavier <[email protected]> * deleted unnecessary constant file for task as this was added to resolve conflicts in the early stages * chore: Restructure media queries on tasks module Signed-off-by: Aneena John Xavier <[email protected]> --------- Signed-off-by: Aneena John Xavier <[email protected]> Co-authored-by: Aneena John Xavier <[email protected]> Co-authored-by: Sunny Sahsi <[email protected]>
* fix getIdleSinceText function * Update src/helperFunctions/getIdleSinceText.ts Co-authored-by: Shubham Kumar Singh <[email protected]> * Update src/helperFunctions/getIdleSinceText.ts * Update src/helperFunctions/getIdleSinceText.ts * Update src/helperFunctions/getIdleSinceText.ts * Update src/helperFunctions/getIdleSinceText.ts * refactor code * change variable name --------- Co-authored-by: Yash Raj <[email protected]> Co-authored-by: Shubham Kumar Singh <[email protected]> Co-authored-by: Achintya Chatterjee <[email protected]>
There was a problem hiding this comment.
I am seeing @Ajeyakrishna-k @aneenajohn changes
please ask them to fill the form
My changes are already in prod. |
iamitprakash
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Number(s):-
Issue Ticket Number:-
Developer name:- @skv93-coder @anishpawaskar
Backend changes
Frontend Changes
Is Under Feature Flag
Database changes
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
Deployment notes
Any special instructions for the deployment - No
Tested in staging
List of PRs going in this Sync.
Also attach their screenshots.
Task status without feature flag
Idle users :-
note: we don't have any idle user on staging so added dev screenshot
Removed filter
