Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature flag from showing the status in task card and handle edit view. #969

Merged
merged 8 commits into from
Oct 29, 2023

Conversation

skv93-coder
Copy link
Contributor

@skv93-coder skv93-coder commented Oct 26, 2023

Developer Name: @skv93-coder

Issue Ticket Number:- #936 , #967

Description:

Show the task status on task card.

Anthing you would like to inform the reviewer about:

No

Backend changes

No

Frontend Changes

Yes

Is Under Feature Flag

No

Database changes

No

Breaking changes (If your feature is breaking/missing something please mention pending tickets)

No

Deployment notes

Any special instructions for the deployment

No

Tested in staging

No

Dev Tested:

Yes

Images/video of the change:

image

Prev
image

New
image

Follow-up Issues (if any)

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
status-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2023 11:56am

@skv93-coder skv93-coder changed the title Remove feature flag from showing the status in task card. Remove feature flag from showing the status in task card and handle edit view. Oct 27, 2023
@shubhamjaintech
Copy link
Contributor

Looks good to me!

renderWithRouter(
<Provider store={store()}>
<Card {...DEFAULT_PROPS} />
</Provider>,
{ query: { dev: 'true' } }
{}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this this "{}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the bracket

@iamitprakash iamitprakash merged commit 427c01e into develop Oct 29, 2023
2 checks passed
@iamitprakash iamitprakash deleted the feature/show-status branch October 29, 2023 11:56
@skv93-coder skv93-coder mentioned this pull request Oct 31, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants