generated from Real-Dev-Squad/website-template
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove feature flag from showing the status in task card and handle edit view. #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
skv93-coder
changed the title
Remove feature flag from showing the status in task card.
Remove feature flag from showing the status in task card and handle edit view.
Oct 27, 2023
Looks good to me! |
iamitprakash
previously requested changes
Oct 28, 2023
renderWithRouter( | ||
<Provider store={store()}> | ||
<Card {...DEFAULT_PROPS} /> | ||
</Provider>, | ||
{ query: { dev: 'true' } } | ||
{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this this "{}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed the bracket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer Name: @skv93-coder
Issue Ticket Number:- #936 , #967
Description:
Show the task status on task card.
Anthing you would like to inform the reviewer about:
No
Backend changes
No
Frontend Changes
Yes
Is Under Feature Flag
No
Database changes
No
Breaking changes (If your feature is breaking/missing something please mention pending tickets)
No
Deployment notes
Any special instructions for the deployment
No
Tested in staging
No
Dev Tested:
Yes
Images/video of the change:
Prev
New
Follow-up Issues (if any)