Fix/issue 918 - Status Site - Feature flag to remove redundant task status tabs #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 6, 2023 17:25
…rger devices and Select dropdown task filter for smaller devices are removed Signed-off-by: Aneena John Xavier <[email protected]>
- Fixed failing test cases for seacrch button handler and input search param handling test cases on tasks pages - Removed test cases corresponding to tabs component. - Removed unneccesary import and variables corresponding to Tabs component in TasksContent.tsx - css classes removed for the same in tasks scss module Signed-off-by: Aneena John Xavier <[email protected]>
Signed-off-by: Aneena John Xavier <[email protected]>
|
Someone is attempting to deploy a commit to the RDS-Team Team on Vercel. A member of the Team first needs to authorize it. |
Signed-off-by: Aneena John Xavier <[email protected]>
Signed-off-by: Aneena John Xavier <[email protected]>
…n single click on test Signed-off-by: Aneena John Xavier <[email protected]>
|
Please add test coverage report or screenshot. |
Please find the complete report below: |
|
Can you add a feature flag to show the secondary dropdown? Because we did not discuss it with @ankurnarkhede and @iamitprakash (Tejas) to remove it. |
|
added 9 commits
October 11, 2023 18:58
…tatus into fix/issue-918-remove-redundant-tab-section
…tatus into fix/issue-918-remove-redundant-tab-section
…github.com/aneenajohn/website-status into fix/issue-918-remove-redundant-tab-section
…tatus into fix/issue-918-remove-redundant-tab-section
… into fix/issue-918-remove-redundant-tab-section
…tatus into fix/issue-918-remove-redundant-tab-section
- The secondary dropdown will be rendered on UI only with feature flag (ie) when dev is passed as true in queryparam `?dev=true` - Updated task container css to compensate for the width reduction when the secondary status tab is removed. - Test cases updated to test the secondary tabs only when dev is true Signed-off-by: Aneena John Xavier <[email protected]>
Signed-off-by: Aneena John Xavier <[email protected]>
…tatus into fix/issue-918-remove-redundant-tab-section
added 4 commits
October 23, 2023 08:35
…tatus into fix/issue-918-remove-redundant-tab-section
…t render secondary tabs Signed-off-by: Aneena John Xavier <[email protected]>
…tatus into fix/issue-918-remove-redundant-tab-section
…title and desc should not with same values case Signed-off-by: Aneena John Xavier <[email protected]>
|
@shubhamsigdar1 / @sahsisunny / @iamitprakash Please review |
iamitprakash
requested changes
Oct 25, 2023
There was a problem hiding this comment.
Want to know you taken latest pull from develop because my pr got merged #960
aneenajohn
changed the title
@shubhamsigdar1, Yes latest pull from develop is taken into this working branch
|
Updated now, please check |
aneenajohn
changed the title
aneenajohn
changed the title
aneenajohn
changed the title
Pratiyushkumar
previously requested changes
Oct 27, 2023
added 2 commits
October 27, 2023 12:38
Signed-off-by: Aneena John Xavier <[email protected]>
Signed-off-by: Aneena John Xavier <[email protected]>
added 2 commits
October 27, 2023 18:18
…ve conflicts in the early stages
Signed-off-by: Aneena John Xavier <[email protected]>
iamitprakash
approved these changes
Oct 27, 2023
iamitprakash
approved these changes
Oct 27, 2023
Pratiyushkumar
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #918 - Remove redundant second task status filter by tabs
Description:
There are two ways to filter the tasks based on task status on Tasks Page as shown below.
Anything you would like to inform the reviewer about:
Dev Tested:
Is Under Feature Flag:
Images/video of the change:
Large Screens Before:
Small Screens Before:
Video Reference:
After:
remove-secondary-task-tabs.mp4
Follow-up Issues (if any)
NA