Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed timestamp issue in review statement #511

Merged

Conversation

joyguptaa
Copy link
Contributor

@joyguptaa joyguptaa commented Oct 29, 2023

Developer Name: Joy Gupta

Purpose

Reviewed log should show the timestamp when the request was reviewed and not when it was created

PR Number(s): 511

Issue Ticket

Proposal Doc

https://docs.google.com/document/d/1sf-BAs7C6wmfjRVS-82X492hcb_7jAfIM-7pWtizuXE/edit

Frontend Changes

  • Yes
  • No

Is Under Feature Flag

  • Yes
  • No

Database changes:

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets):

  • Yes
  • No

Deployment notes:

NA

Tested in local

  • Yes
  • No

List of PRs going in this Sync

QA Instructions, Screenshots, Recordings

Run yarn test:ember and there you can see test case running.
Screenshot 2023-10-29 at 11 45 23

Working Proof

This extension request was made 1 week ago and was approved few hours ago

Before:
Screenshot 2023-10-29 at 11 39 57

After:
Screenshot 2023-10-29 at 11 40 17

@netlify
Copy link

netlify bot commented Oct 29, 2023

Deploy Preview for staging-my ready!

Name Link
🔨 Latest commit 6a87558
🔍 Latest deploy log https://app.netlify.com/sites/staging-my/deploys/653df93618f7330008bdcf81
😎 Deploy Preview https://deploy-preview-511--staging-my.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shubhamsinghbundela
Copy link
Contributor

Link issue ticket please.

Copy link
Contributor

@shubhamsinghbundela shubhamsinghbundela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't understand clearly what you trying to achieve in this pr

What I understand- log show timestamp after extension request approved

correct me if understand wrong

Copy link
Contributor

@shubhamsinghbundela shubhamsinghbundela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is meaning of reviewed here??

@joyguptaa
Copy link
Contributor Author

This feature is related to the audit log. A user who has submitted an extension request should be able to see who has reviewed it. To achieve this, we are using 'reviewedBy.' It should also display when it was reviewed. Previously, I was using 'timestamp,' which actually indicates when the extension request was created. However, I have now replaced it with 'reviewedAt,' which denotes when the request was reviewed.

Screenshot 2023-10-29 at 7 47 34 PM

Copy link
Contributor

@shubhamsinghbundela shubhamsinghbundela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is test written for this changes??

@joyguptaa
Copy link
Contributor Author

Where is test written for this changes??

It's already been written. You check it here in the screenshot
Screenshot 2023-10-29 at 8 08 46 PM

@iamitprakash iamitprakash merged commit bb84be9 into Real-Dev-Squad:develop Oct 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants