-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed timestamp issue in review statement #511
Fixed timestamp issue in review statement #511
Conversation
✅ Deploy Preview for staging-my ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Link issue ticket please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't understand clearly what you trying to achieve in this pr
What I understand- log show timestamp after extension request approved
correct me if understand wrong
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is meaning of reviewed here??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is test written for this changes??
Developer Name: Joy Gupta
Purpose
Reviewed log should show the timestamp when the request was reviewed and not when it was created
PR Number(s): 511
Issue Ticket
Proposal Doc
https://docs.google.com/document/d/1sf-BAs7C6wmfjRVS-82X492hcb_7jAfIM-7pWtizuXE/edit
Frontend Changes
Is Under Feature Flag
Database changes:
Breaking changes (If your feature is breaking/missing something please mention pending tickets):
Deployment notes:
NA
Tested in local
List of PRs going in this Sync
QA Instructions, Screenshots, Recordings
Run
yarn test:ember
and there you can see test case running.Working Proof
This extension request was made 1 week ago and was approved few hours ago
Before:
After: