Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore : Added timestamp of logs in self ER request #1635

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Chore : Added timestamp of logs in self ER request #1635

merged 1 commit into from
Oct 29, 2023

Conversation

joyguptaa
Copy link
Contributor

@joyguptaa joyguptaa commented Oct 29, 2023

Developer Name: Joy Gupta

Purpose

Reviewed log should show the timestamp when the request was reviewed and not when it was created

PR Number(s): 1635

Backend Changes

  • Yes
  • No

Is Under Feature Flag

  • Yes
  • No

Database changes:

  • Yes
  • No

Breaking changes (If your feature is breaking/missing something please mention pending tickets):

  • Yes
  • No

Deployment notes:

NA

Tested in local

  • Yes
  • No

List of PRs going in this Sync

QA Instructions, Screenshots, Recordings

Screenshot 2023-10-29 at 11 49 07

Working Proof

Screenshot 2023-10-29 at 11 54 41

@joyguptaa
Copy link
Contributor Author

Out of all 3 test cases were failing which usually fails.
Currently, this test case is failing which has nothing to do with my changes.
Screenshot 2023-10-29 at 11 58 38

Copy link
Contributor

@shubhamsinghbundela shubhamsinghbundela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failing

@joyguptaa
Copy link
Contributor Author

Test failing

If you could rerun the checks, I believe it will work because this test case is in no way related to my changes. Also, the error message from the test case indicates that it is somewhat related to a connection issue.

@iamitprakash iamitprakash merged commit a69d38b into Real-Dev-Squad:develop Oct 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants