Fix qvm-copy behavior with symlinks #548
Conversation
FIXES `qubes-fs-tree-check: Refusing to copy unsafe symbolic link "dir//link"` when you run `qvm-copy dir/`
Previously, `qvm-copy --ignore-symlinks` could result in `qubes-fs-tree-check: Refusing to copy unsafe symbolic link`
fixes bug introduced in previous commit
|
@marmarek Thanks for catching that! How does it look now? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #548 +/- ##
==========================================
- Coverage 70.57% 70.14% -0.43%
==========================================
Files 3 3
Lines 469 469
==========================================
- Hits 331 329 -2
- Misses 138 140 +2 ☔ View full report in Codecov by Sentry. |
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025012002-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update
Failed tests96 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/119126#dependencies 3 fixed
Unstable tests |
Previously,
qvm-copyhad a couple of issues with symlinks:but
qvm-copy-to-vm untrusted dirworked fine.qvm-copy --ignore-symlinkscould still throwqubes-fs-tree-check: Refusing to copy unsafe symbolic link. If we are ignoring symlinks,qubes-fs-tree-checkshould not check for them.Notes
Running
qubes-fs-tree-check --ignore-symlinks --allow-symlinksdoes not seem to cause an issue.