Remove hostname dependency for Archlinux

[alimirjamali]

fixes: QubesOS/qubes-issues#9710

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.57%. Comparing base (74d07bb) to head (d0cab32).
Report is 6 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #547   +/-   ##
=======================================
  Coverage   70.57%   70.57%           
=======================================
  Files           3        3           
  Lines         469      469           
=======================================
  Hits          331      331           
  Misses        138      138           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[qubesos-bot]

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025012310-4.3&flavor=pull-requests

Test run included the following:

• Add filter for qubes stored on inaccessible storage pools qubes-manager#399 (QubesOS/qubes-manager@7dcb8b7)
• tests: add support for testing updates of Archlinux template qubes-core-admin#648 (QubesOS/qubes-core-admin@a784c37)
• Remove hostname dependency for Archlinux #547 (d0cab32)
• Relabel / and /rw if needed #541 (31bb12a)
• Stop using qubes-rpc-multiplexer qubes-core-qrexec#141 (QubesOS/qubes-core-qrexec@51460e6)
• archlinux: package tools for fetching dom0 updates #549 (e4ecb43)
• Package for Arch qubes-repo-templates#6 (QubesOS/qubes-repo-templates@50757e6)
• archlinux: install pdf-converter by default qubes-meta-packages#76 (QubesOS/qubes-meta-packages@a55be4d)
• Rebuild for Arch qubes-app-linux-pdf-converter#33 (QubesOS/qubes-app-linux-pdf-converter@e49eab2)
• tests: add qrexec performance tests qubes-core-admin#647 (QubesOS/qubes-core-admin@94a3621)
• SystemD dropins for minimal sys-net and sys-usb #540 (f4b3d19)
• Add Arch packaging qubes-core-admin-client#332 (QubesOS/qubes-core-admin-client@392f8a3)
• Replace pulseaudio with pipewire for Archlinux qubes-meta-packages#75 (QubesOS/qubes-meta-packages@c790dd8)

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2024111705-4.3&flavor=update

• system_tests_network_updates

  • TC_11_QvmTemplateMgmtVM_whonix-gateway-17: test_010_template_install (failure)
    qvm-template: error: Template 'debian-12-minimal' not found.

• system_tests_dispvm

  • TC_20_DispVM_fedora-41-xfce: test_100_open_in_dispvm (failure)
    AssertionError: './open-file test.txt' failed with ./open-file test...

• system_tests_kde_gui_interactive

  • gui_keyboard_layout: wait_serial (wait serial expected)
    # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

• system_tests_guivm_vnc_gui_interactive

  • gui_filecopy: unnamed test (unknown)
  • gui_filecopy: Failed (test died)
    # Test died: no candidate needle with tag(s) 'file-copy-prompt' mat...

• system_tests_basic_vm_qrexec_gui_ext4

  • TC_30_Gui_daemon: test_002_clipboard_300k (failure)
    : Clipboard copy operation failed - content...

• system_tests_guivm_gui_interactive

  • clipboard_and_web: unnamed test (unknown)
  • clipboard_and_web: Failed (test died)
    # Test died: no candidate needle with tag(s) 'clipboard-copy-notifi...

Failed tests

10 failures

• system_tests_network_updates

  • TC_11_QvmTemplateMgmtVM_whonix-gateway-17: test_010_template_install (failure)
    qvm-template: error: Template 'debian-12-minimal' not found.

• system_tests_dispvm

  • TC_20_DispVM_fedora-41-xfce: test_100_open_in_dispvm (failure)
    AssertionError: './open-file test.txt' failed with ./open-file test...

• system_tests_kde_gui_interactive

  • gui_keyboard_layout: wait_serial (wait serial expected)
    # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

  • gui_keyboard_layout: Failed (test died)
    # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

• system_tests_basic_vm_qrexec_gui_zfs

  • switch_pool: Failed (test died)
    # Test died: command 'qubes-dom0-update -y zfs' failed at /usr/lib/...

• system_tests_guivm_vnc_gui_interactive

  • gui_filecopy: unnamed test (unknown)
  • gui_filecopy: Failed (test died)
    # Test died: no candidate needle with tag(s) 'file-copy-prompt' mat...

• system_tests_basic_vm_qrexec_gui_ext4

  • TC_30_Gui_daemon: test_002_clipboard_300k (failure)
    : Clipboard copy operation failed - content...

• system_tests_guivm_gui_interactive

  • clipboard_and_web: unnamed test (unknown)
  • clipboard_and_web: Failed (test died)
    # Test died: no candidate needle with tag(s) 'clipboard-copy-notifi...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/119126#dependencies

2 fixed

• system_tests_extra

  • TC_00_QVCTest_whonix-gateway-17: test_010_screenshare (failure)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^... AssertionError: 0 == 0

• system_tests_audio@hw1

  • TC_20_AudioVM_PipeWire_whonix-workstation-17: test_260_audio_mic_enabled_switch_audiovm (failure)
    AssertionError: too short audio, expected 10s, got 0.00013605442176...

Unstable tests

[marmarek]

There is more: hostname is also set on the VM startup: https://github.com/QubesOS/qubes-core-agent-linux/blob/main/vm-systemd/qubes-early-vm-config.sh#L22

[alimirjamali]

There is more: hostname is also set on the VM startup: https://github.com/QubesOS/qubes-core-agent-linux/blob/main/vm-systemd/qubes-early-vm-config.sh#L22

This one uses the SET NAME feature of hostname command. I will modify the bash script to check for the existence of /usr/bin/hostname and revert to hostnamectl if it does not exist to use hostnamectl as it is only applicable for systemd. I will also change cat /etc/hostname to hostnamectl hostname in the original PR as suggested by @Justasic

[marmarek]

Now setting hostname is broken on Fedora (at least): https://openqa.qubes-os.org/tests/126217#step/screenlocker_idle_watch/10 (see that hostname remained "fedora", should be "work).

[marmarek]

Logs say:

[2025-01-21 05:39:58] [    4.550584] hostnamectl[512]: �[0;1;31mFailed to connect to system scope bus via local transport: No such file or directory�[0m

I guess it's too early for hostnamed service...

[alimirjamali]

I guess it's too early for hostnamed service...

Maybe $(echo "$name" > /etc/hostname) could work but it is a little bit ugly.

[marmarek]

But will that be enough? Something needs to actually make the sethostname syscall...
Maybe writing to /proc/sys/kernel/hostname will be enough?

[alimirjamali]

But will that be enough? Something needs to actually make the sethostname syscall... Maybe writing to /proc/sys/kernel/hostname will be enough?

Does not work with root. I get Permission denied on echo something > /proc/sys/kernel/hostname.

[alimirjamali]

I modified it a little bit (only try alternative solution if hostname binary does not exist). And trying to write $nameto/etc/hostname`, hoping systemd would pick it up on archlinux

[marmarek]

Does not work with root. I get Permission denied on echo something > /proc/sys/kernel/hostname.

You sure you haven't done the classic sudo echo pitfall? Writing there does work for me...

[marmarek]

Anyway, I guess /etc/hostname needs to be written to too (if exists)

[alimirjamali]

Anyway, I guess /etc/hostname needs to be written to too (if exists)

I amended the PR to write to both. Hope it works well this time.

[marmarek]

What should happen if /etc/hostname is missing? For example I don't see this file on Fedora. But hostnamectl hostname something does create it, so maybe the current version is fine?

[alimirjamali]

What should happen if /etc/hostname is missing? For example I don't see this file on Fedora. But hostnamectl hostname something does create it, so maybe the current version is fine?

The way I modified the script (my last commit), it uses hostname if it exists (on Fedora & Debian machines). So nothing has really changed on Fedora & Debian. On Archlinux, it should create /etc/hostname and update /proc/sys/kernel/hostname to be on the safe side.