feat(funnels): use hogql for legacy insight funnels api

posthog/api/insight.py

@@ -1103,7 +1103,12 @@
         timings = HogQLTimings()
         try:
             with timings.measure("calculate"):
-                funnel = self.calculate_funnel(request)
+                query_method = get_query_method(request=request, team=self.team)
+                if query_method == "hogql":
+                    funnel = self.calculate_funnel_hogql(request)
+                else:
+                    funnel = self.calculate_funnel(request)
+
         except ExposedHogQLError as e:
             raise ValidationError(str(e))
 
@@ -1112,7 +1117,7 @@
 
         return Response(funnel)
 
-    @cached_by_filters
+    # @cached_by_filters
     def calculate_funnel(self, request: request.Request) -> dict[str, Any]:
         team = self.team
         filter = Filter(request=request, data={"insight": INSIGHT_FUNNELS}, team=self.team)
@@ -1134,6 +1139,20 @@
                 "timezone": team.timezone,
             }
 
+    # @cached_by_filters
+    def calculate_funnel_hogql(self, request: request.Request) -> dict[str, Any]:
+        team = self.team
+        filter = Filter(request=request, team=team)
+        filter = filter.shallow_clone(overrides={"insight": "FUNNELS"})
+        query = filter_to_query(filter.to_dict())
+        query_runner = get_query_runner(query, team, limit_context=None)
+
+        # we use the legacy caching mechanism (@cached_by_filters decorator), no need to cache in the query runner
+        result = query_runner.run(execution_mode=ExecutionMode.CALCULATE_BLOCKING_ALWAYS)
+        # assert isinstance(result, schema.CachedFunnelsQueryResponse)
+
+        return {"result": result.results, "timezone": team.timezone}
+
     # ******************************************
     # /projects/:id/insights/retention
     # params:

posthog/api/test/test_insight.py

@@ -3055,6 +3055,7 @@ def test_insight_funnels_hogql_local_filters(self) -> None:
 
     @snapshot_clickhouse_queries
     @also_test_with_materialized_columns(event_properties=["int_value"], person_properties=["fish"])
+    @override_settings(PERSON_ON_EVENTS_OVERRIDE=False, PERSON_ON_EVENTS_V2_OVERRIDE=False)
     def test_insight_funnels_hogql_breakdown(self) -> None:
         with freeze_time("2012-01-15T04:01:34.000Z"):
             _create_person(